-
Notifications
You must be signed in to change notification settings - Fork 619
Handle page crash when rendering NFTs with unexpected title, description values #5095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle page crash when rendering NFTs with unexpected title, description values #5095
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5095 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1059 1059
Lines 54754 54754
Branches 3957 3959 +2
=======================================
Hits 24804 24804
Misses 29259 29259
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Merge activity
|
…ion values (#5095) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces error handling components to display messages for unexpected values in the NFT-related pages, enhancing user experience by providing feedback when data does not meet expectations. ### Detailed summary - Added `react-error-boundary` to handle errors. - Created `UnexpectedValueErrorMessage` component for displaying error messages. - Integrated error handling in `TokenIdPage`, `NFTName`, and `NFTDescription` components. - Updated `NFTGetAllTable` to use `UnexpectedValueErrorMessage` for invalid data. - Wrapped NFT cell rendering in `ErrorBoundary` to catch errors. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
09d0b86 to
1a45f21
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces the
react-error-boundarypackage and enhances error handling in the NFT-related components by implementingUnexpectedValueErrorMessage. It improves user feedback for invalid data in theTokenIdPageandNFTGetAllTable.Detailed summary
react-error-boundaryto handle errors gracefully.UnexpectedValueErrorMessagecomponent for displaying error messages.TokenIdPage.NFTGetAllTableto useUnexpectedValueErrorMessagefor invalid NFT data.ErrorBoundaryfor better error management.