Skip to content

Conversation

@edwardysun
Copy link
Contributor

@edwardysun edwardysun commented Oct 22, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a project showcase feature for a dashboard application, enhancing the display of various web3 projects with detailed information and pagination.

Detailed summary

  • Added new project showcase pages in page.tsx and DetailPage component.
  • Implemented project data management with PROJECT_SHOWCASE_DATA.
  • Introduced UI components like Card, Badge, and Button.
  • Included image handling with next/image for project visuals.
  • Enhanced navigation with pagination in the project listing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@edwardysun edwardysun added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 22, 2024
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 2a63677

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:32am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:32am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:32am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:32am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 531 ms (-0.28% 🔽) 1.4 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.3 s (+13.16% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 27 ms (-14.69% 🔽) 124 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 14 ms (+83.26% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 329 ms (+499.21% 🔺) 676 ms

@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (5dc1899) to head (2a63677).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5118   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3971     3971           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5dc1899
packages 40.38% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 04:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 03:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 03:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 03:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 25, 2024 06:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 25, 2024 06:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 25, 2024 06:13 Inactive
Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - only thing i would recommend is moving it out of /(dashboard) so you dont have the default header (with the connect/contract/etc tabs)

you can just move it to /app instead so you get the full page

},
};

export const dynamic = "force-dynamic";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you actually need this?

@edwardysun
Copy link
Contributor Author

Sounds good, I believe we actually wanted to have the header. I'll get this in first and we can iterate on that part

@edwardysun edwardysun merged commit 9dfe4af into main Oct 25, 2024
30 checks passed
@edwardysun edwardysun deleted the biz-hackweek-project-showcase branch October 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants