[SDK] ERC721 claimToBatch extension #5124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5124 +/- ##
==========================================
+ Coverage 45.38% 45.45% +0.06%
==========================================
Files 1064 1065 +1
Lines 55054 55122 +68
Branches 3965 3975 +10
==========================================
+ Hits 24986 25054 +68
Misses 29376 29376
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more.
|
kien-ngo
force-pushed
the
kien/claimToBatch
branch
from
c2c6084 to
7c8ec29
Compare
kien-ngo
commented
Oct 22, 2024
gregfromstl
reviewed
Oct 22, 2024
|
|
||
| describe.runIf(process.env.TW_SECRET_KEY)("ERC721: claimTo", () => { | ||
| it("isClaimToSupported should work", async () => { | ||
| const contract = getContract({ |
Contributor
There was a problem hiding this comment.
Can we run this test against an existing contract? That way we don't rely on deploy which hits IPFS
gregfromstl
approved these changes
Oct 22, 2024
gregfromstl
added
the
merge-queue
Contributor
Merge activity
|
gregfromstl
pushed a commit
that referenced
this pull request
Oct 22, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces the `claimToBatch` functionality for the `ERC721` extension, allowing multiple NFT claims in a single transaction. It includes new tests for this feature and optimizes the claim content processing.
### Detailed summary
- Added `claimToBatch` function in `claimToBatch.ts` for batch NFT claims.
- Introduced `ClaimToBatchParams` type for defining batch claim parameters.
- Implemented `optimizeClaimContent` function to combine identical recipient claims.
- Created tests for `claimToBatch` and `optimizeClaimContent` in `claimToBatch.test.ts`.
- Updated `erc721.ts` to export `claimToBatch` and related types.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
kien/claimToBatch
branch
from
7c8ec29 to
e952120
Compare
graphite-app
bot
removed
the
merge-queue
kien-ngo
force-pushed
the
kien/claimToBatch
branch
from
e952120 to
902675f
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces the `claimToBatch` functionality for the `ERC721` extension, allowing multiple claims in a single transaction. It includes tests to ensure the optimization of claim content and the correct processing of batch claims.
### Detailed summary
- Added `claimToBatch` function in `claimToBatch.ts` for batch claiming NFTs.
- Introduced `ClaimToBatchParams` type to define batch claim structure.
- Implemented `optimizeClaimContent` function to consolidate identical recipient claims.
- Created tests for `claimToBatch` and `optimizeClaimContent` in `claimToBatch.test.ts`.
- Verified the functionality of `isClaimToSupported` in the test suite.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/claimToBatch
branch
from
902675f to
c32576f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces the
claimToBatchfunctionality for theERC721extension, allowing multiple claims in a single transaction and optimizing claim content. It includes tests for the new feature and ensures that the claiming process works as intended.Detailed summary
claimToBatchfunction inclaimToBatch.tsfor batching claims.ClaimToBatchParamstype for input parameters.optimizeClaimContentto consolidate identical recipient claims.claimToBatchandoptimizeClaimContentinclaimToBatch.test.ts.