[SDK] Options to custonize ViewAssets's tabs #5126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c621c13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5126 +/- ##
=======================================
Coverage 45.36% 45.37%
=======================================
Files 1067 1067
Lines 55433 55450 +17
Branches 3991 3991
=======================================
+ Hits 25148 25161 +13
- Misses 29594 29598 +4
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
suggested changes
Oct 22, 2024
Contributor
gregfromstl
left a comment
gregfromstl
left a comment
There was a problem hiding this comment.
I don't think we should make this change. It's incredibly niche and if they want this level of customization they should probably be building their own UI. It'll also break as soon as we add another tab to this screen.
packages/thirdweb/src/react/core/hooks/connection/ConnectButtonProps.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
We were having a discussion here: https://linear.app/thirdweb/issue/CNCT-2036/feedbackfeature-request-on-nfts-tab |
kien-ngo
force-pushed
the
kien/cnct-2036_view-funds-tabs
branch
from
20663a1 to
5486d5e
Compare
github-actions
bot
added
the
Playground
kien-ngo
force-pushed
the
kien/cnct-2036_view-funds-tabs
branch
from
5486d5e to
336eb86
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kien-ngo
force-pushed
the
kien/cnct-2036_view-funds-tabs
branch
2 times, most recently
from
782a86a to
8b87882
Compare
Contributor
Okay I guess I'm overruled then |
gregfromstl
approved these changes
Nov 1, 2024
gregfromstl
added
the
merge-queue
Contributor
Merge activity
|
gregfromstl
pushed a commit
that referenced
this pull request
Nov 1, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `ConnectButton` component by allowing customization of the asset tab display order in the "View Assets" section. Users can now specify whether to show the "Tokens" or "NFTs" tab first, and an empty array will hide the "View Funds" button.
### Detailed summary
- Added `assetTabs` prop to `ConnectButton` for customizing asset tab order.
- Updated `ViewAssets` to dynamically render tabs based on `assetTabs` prop.
- Modified `DetailsModal` to conditionally display "View Funds" button based on `assetTabs` length.
- Enhanced documentation with instructions for using the new feature.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
kien/cnct-2036_view-funds-tabs
branch
from
8b87882 to
dd8c382
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces the ability to customize the display order of asset tabs in the `ConnectButton` component, allowing users to prioritize "NFTs" over "Tokens". It also includes updates to the documentation and type definitions to support this feature.
### Detailed summary
- Added customization for asset tab order in `ConnectButton`.
- Default order shows "Tokens" first; can be changed to `["nft", "token"]`.
- Updated type definitions to include `assetTabs` in `ConnectButtonProps`.
- Modified `ViewAssets` to dynamically render tabs based on `assetTabs`.
- Documentation updated to reflect changes in tab customization.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
kien/cnct-2036_view-funds-tabs
branch
from
dd8c382 to
c621c13
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces a feature to customize the display order of asset tabs in the
ConnectButtoncomponent, allowing users to prioritize "NFTs" or "Tokens". It also includes updates to related components and documentation.Detailed summary
ConnectButton.ViewAssetsto dynamically set active tab based onassetTabsprop.DetailsModalto hide the "View Funds" button ifassetTabsis an empty array.