[SDK] Fix: Prevent Duplicated RDNS Values from WalletConnect #5129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
added
the
Bug
🦋 Changeset detectedLatest commit: 319a203 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
force-pushed
the
fix/brave-wallet
branch
from
a54be24 to
7885eb4
Compare
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5129 +/- ##
==========================================
- Coverage 45.30% 45.30% -0.01%
==========================================
Files 1060 1060
Lines 54874 54874
Branches 3957 3957
==========================================
- Hits 24862 24860 -2
- Misses 29320 29322 +2
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
joaquim-verges
approved these changes
Oct 22, 2024
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
Fixes #5116 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating wallet metadata and image assets for various wallets in the `thirdweb` project. It includes changes to wallet IDs, homepages, image IDs, and mobile app links, ensuring accurate information for wallet integration. ### Detailed summary - Removed the file `lovely-items-live.md`. - Updated `native` and `universal` links for `finance.plena` and `finance.openwallet`. - Changed `image_id` for `Crypto.com`, `Status`, `Coin98`, and others. - Added new wallet entries for `com.daffione`, `com.beexo`, `id.plumaa`, `io.owallet`, and `com.ipmb`. - Updated `getWalletInfo` method to include new wallets and remove `org.nitrogen` and `com.brave.wallet`. - Added new images for several wallets as base64 encoded data. - Updated the count of supported wallets in `wallet-ids.ts` and `wallet-infos.ts`. > The following files were skipped due to too many changes: `packages/thirdweb/src/wallets/__generated__/wallet/com.coin98/image.ts`, `packages/thirdweb/src/wallets/__generated__/wallet/app.status/image.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
fix/brave-wallet
branch
from
7885eb4 to
319a203
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5116
PR-Codex overview
This PR focuses on updating wallet metadata and image assets for various wallets within the
thirdwebproject, including renaming, adding new wallets, and modifying existing wallet configurations.Detailed summary
org.nitrogenwallet and replaced it withcom.webauth.com.brave.walletto reflect the new name and homepage.com.daffione,com.beexo,id.plumaa,io.owallet, andcom.ipmb.