Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 22, 2024

Don't merge - running into issues with package imports inside local thirdweb package

also, need to literally test all the pages before merging this

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:36pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:36pm
thirdweb-www ❌ Failed (Inspect) Oct 22, 2024 8:36pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:36pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: d2079ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 22, 2024 20:25
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 22, 2024
Copy link
Member Author

MananTank commented Oct 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as draft October 22, 2024 20:25
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@next/[email protected] Transitive: environment, filesystem, network, shell +18 2.31 MB vercel-release-bot
npm/@next/[email protected] Transitive: filesystem +18 587 kB matt.straka, rauchg, timer, ...2 more
npm/@vercel/[email protected] None 0 79.5 kB vercel-release-bot
npm/[email protected] environment, filesystem, network, shell, unsafe +13 107 MB vercel-release-bot

🚮 Removed packages: npm/@next/[email protected]

View full report↗︎

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 3.5 s (+5.74% 🔺) 4.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 7.5 s (-1.75% 🔽) 9.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 259 ms (+75.95% 🔺) 356 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 82 ms (+71.95% 🔺) 92 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 546 ms (+26.65% 🔺) 893 ms

@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.28%. Comparing base (9c3ff94) to head (d2079ac).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5131      +/-   ##
==========================================
- Coverage   45.28%   45.28%   -0.01%     
==========================================
  Files        1060     1060              
  Lines       54831    54841      +10     
  Branches     3955     3956       +1     
==========================================
+ Hits        24832    24836       +4     
- Misses      29308    29314       +6     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9c3ff94
packages 40.23% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants