Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 22, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on modifying the onClick function in the useSendTransaction.tsx file to improve the formatting of the prepareContractCall function call.

Detailed summary

  • Removed unnecessary indentation from the prepareContractCall parameters.
  • Adjusted the formatting for better readability while keeping the same logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:33pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:33pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:33pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:33pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 8f7fbed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 22, 2024 22:22
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 2.5 s (-16.13% 🔽) 3.4 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 6.3 s (-18.27% 🔽) 8.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 201 ms (+36.07% 🔺) 298 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 174 ms (+268.73% 🔺) 184 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 482 ms (+50.95% 🔺) 830 ms

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (364d97e) to head (8f7fbed).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5133   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1060     1060           
  Lines       54874    54874           
  Branches     3957     3960    +3     
=======================================
  Hits        24862    24862           
  Misses      29320    29320           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 364d97e
packages 40.26% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...react/web/hooks/transaction/useSendTransaction.tsx 31.25% <ø> (ø)

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 3c77c6b into main Oct 23, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the fix_correct_indentation_in_useSendTransaction_example branch October 23, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants