[SDK] Consolidate ERC1155 Drop tests #5137

kien-ngo · 2024-10-23T07:30:58Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on removing outdated tests and refactoring the TEST_ACCOUNT references in the erc1155 test files, while adding new functionality for updating metadata and claiming tokens without payment under certain conditions.

Detailed summary

Deleted claimTo.test.ts and updateMetadata.test.ts.
Updated getActiveClaimCondition tests in getActiveClaimCondition.test.ts.
Changed references from TEST_ACCOUNT_A to TEST_ACCOUNT_C in multiple tests.
Added a test for updating metadata.
Added a test for claiming tokens without payment.
Added a test for getActiveClaimCondition functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-23T07:31:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2024 6:14am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2024 6:14am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2024 6:14am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2024 6:14am

changeset-bot · 2024-10-23T07:31:04Z

⚠️ No Changeset found

Latest commit: 53e9d8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-23T07:31:04Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-10-23T07:31:18Z

[SDK] Consolidate ERC1155 Drop tests #5137 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-10-23T07:34:20Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.9 KB (0%)	859 ms (0%)	560 ms (+4.02% 🔺)	1.5 s
thirdweb (cjs)	102.73 KB (0%)	2.1 s (0%)	1.2 s (-1.84% 🔽)	3.2 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	35 ms (-11.1% 🔽)	132 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	53 ms (+566.53% 🔺)	63 ms
thirdweb/react (minimal + tree-shaking)	17.34 KB (0%)	347 ms (0%)	283 ms (+193.03% 🔺)	630 ms

codecov · 2024-10-24T06:00:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.44%. Comparing base (9fadbcc) to head (53e9d8b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5137      +/-   ##
==========================================
- Coverage   45.45%   45.44%   -0.01%     
==========================================
  Files        1065     1065              
  Lines       55122    55122              
  Branches     3976     3972       -4     
==========================================
- Hits        25053    25052       -1     
- Misses      29377    29378       +1     
  Partials      692      692

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 9fadbcc
packages	`40.47% <ø> (-0.01%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

graphite-app · 2024-10-24T06:00:57Z

Merge activity

Oct 24, 2:00 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 24, 2:10 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
Oct 24, 2:24 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 24, 2:25 AM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR primarily focuses on refactoring tests for the `erc1155` extension, updating account references, and adding new test cases for metadata updates and claim conditions. ### Detailed summary - Deleted `claimTo.test.ts` and `updateMetadata.test.ts`. - Updated account references from `TEST_ACCOUNT_A` to `TEST_ACCOUNT_C`. - Added a test case for updating metadata. - Added a test case to verify claiming without payment for the primary fee recipient. - Ensured `getActiveClaimCondition` works correctly with new test cases. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kien-ngo marked this pull request as ready for review October 23, 2024 07:31

kien-ngo requested review from gregfromstl, jnsdls and joaquim-verges as code owners October 23, 2024 07:31

github-actions bot added the packages label Oct 23, 2024

vercel bot deployed to Preview – wallet-ui October 23, 2024 07:33 View deployment

vercel bot deployed to Preview – thirdweb_playground October 23, 2024 07:33 View deployment

kien-ngo force-pushed the kien/update-erc1155-drop-tests branch from 566cd43 to ac32aee Compare October 23, 2024 07:38

vercel bot deployed to Preview – wallet-ui October 23, 2024 07:40 View deployment

vercel bot deployed to Preview – thirdweb_playground October 23, 2024 07:40 View deployment

vercel bot deployed to Preview – thirdweb-www October 23, 2024 07:50 View deployment

vercel bot deployed to Preview – docs-v2 October 23, 2024 07:55 View deployment

joaquim-verges approved these changes Oct 23, 2024

View reviewed changes

kien-ngo force-pushed the kien/update-erc1155-drop-tests branch from ac32aee to 53e9d8b Compare October 24, 2024 06:02

vercel bot deployed to Preview – wallet-ui October 24, 2024 06:05 View deployment

vercel bot deployed to Preview – thirdweb_playground October 24, 2024 06:05 View deployment

vercel bot deployed to Preview – thirdweb-www October 24, 2024 06:13 View deployment

vercel bot deployed to Preview – docs-v2 October 24, 2024 06:14 View deployment

graphite-app bot merged commit 53e9d8b into main Oct 24, 2024
28 checks passed

graphite-app bot deleted the kien/update-erc1155-drop-tests branch October 24, 2024 06:25

vercel bot deployed to Production – wallet-ui October 24, 2024 06:27 View deployment

vercel bot deployed to Production – thirdweb_playground October 24, 2024 06:27 View deployment

vercel bot deployed to Production – docs-v2 October 24, 2024 06:28 View deployment

vercel bot deployed to Production – thirdweb-www October 24, 2024 06:35 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Consolidate ERC1155 Drop tests #5137

[SDK] Consolidate ERC1155 Drop tests #5137

Uh oh!

kien-ngo commented Oct 23, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 23, 2024

Uh oh!

kien-ngo commented Oct 23, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 24, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] Consolidate ERC1155 Drop tests #5137

[SDK] Consolidate ERC1155 Drop tests #5137

Uh oh!

Conversation

kien-ngo commented Oct 23, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Oct 23, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 23, 2024 •

edited

Loading

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

kien-ngo commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 24, 2024 •

edited

Loading

graphite-app bot commented Oct 24, 2024 •

edited

Loading