[Dashboard] Add some informative badges to the Explorer #5138
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
=======================================
Coverage 45.43% 45.43%
=======================================
Files 1066 1066
Lines 55150 55150
Branches 3974 3974
=======================================
Hits 25055 25055
Misses 29403 29403
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
| <div className="flex flex-row items-center gap-2"> | ||
| <Heading size="label.sm">Output</Heading> | ||
| {/* Show the Solidity type of the function's output */} | ||
| {abiFunction.outputs.length > 0 && ( |
There was a problem hiding this comment.
is this the right way to retrieve a function's output? Since it's an array I'm not sure about my code here.
There was a problem hiding this comment.
yes, a function MAY have multiple outputs, but usually this should be fine
size-limit report 📦
|
| {fn.stateMutability} | ||
| </Badge> | ||
| {isFunction && <Badge variant="success">{fn.stateMutability}</Badge>} | ||
| {functionSelector && ( |
There was a problem hiding this comment.
Not sure how helpful the function selector is, Deferring this to @jnsdls to decide whether this should be added or not
There was a problem hiding this comment.
feels somewhat not that useful but also doesn't hurt - let's try it for a bit
| {fn.stateMutability} | ||
| </Badge> | ||
| {isFunction && <Badge variant="success">{fn.stateMutability}</Badge>} | ||
| {functionSelector && ( |
There was a problem hiding this comment.
feels somewhat not that useful but also doesn't hurt - let's try it for a bit
| <div className="flex flex-row items-center gap-2"> | ||
| <Heading size="label.sm">Output</Heading> | ||
| {/* Show the Solidity type of the function's output */} | ||
| {abiFunction.outputs.length > 0 && ( |
There was a problem hiding this comment.
yes, a function MAY have multiple outputs, but usually this should be fine
Merge activity
|
kien-ngo
force-pushed
the
kien/add-badge-explorer
branch
from
3b5df1f to
4841ff3
Compare
PR-Codex overview
This PR enhances the user interface of the
InteractiveAbiFunctionandContractFunctionInnercomponents by adding badges to display output types and function state mutability. It also improves layout and introduces a copy button for function selectors.Detailed summary
Badgeto display the Solidity output type inInteractiveAbiFunction.divfor better layout.CopyTextButtonfor copying the function selector inContractFunctionInner.ContractFunctionInnerfor better alignment and responsiveness.