[Dashboard] Add some informative badges to the Explorer #5138

kien-ngo · 2024-10-23T09:07:08Z

PR-Codex overview

This PR enhances the user interface of the InteractiveAbiFunction and ContractFunctionInner components by adding badges to display output types and function state mutability. It also improves layout and introduces a copy button for function selectors.

Detailed summary

Added a Badge to display the Solidity output type in InteractiveAbiFunction.
Wrapped the output heading and badge in a div for better layout.
Introduced a CopyTextButton for copying the function selector in ContractFunctionInner.
Simplified layout structure in ContractFunctionInner for better alignment and responsiveness.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-23T09:07:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 7:01pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 23, 2024 7:01pm
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 23, 2024 7:01pm
wallet-ui	⬜️ Skipped (Inspect)	Oct 23, 2024 7:01pm

changeset-bot · 2024-10-23T09:07:13Z

⚠️ No Changeset found

Latest commit: 4841ff3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-23T09:07:15Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-10-23T09:07:23Z

[Dashboard] Add some informative badges to the Explorer #5138 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

codecov · 2024-10-23T09:08:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.43%. Comparing base (d580fe0) to head (4841ff3).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5138   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files        1066     1066           
  Lines       55150    55150           
  Branches     3974     3974           
=======================================
  Hits        25055    25055           
  Misses      29403    29403           
  Partials      692      692

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from d580fe0
packages	`40.45% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

kien-ngo · 2024-10-23T09:08:40Z

apps/dashboard/src/components/contract-functions/interactive-abi-function.tsx

+              <div className="flex flex-row items-center gap-2">
+                <Heading size="label.sm">Output</Heading>
+                {/* Show the Solidity type of the function's output */}
+                {abiFunction.outputs.length > 0 && (


is this the right way to retrieve a function's output? Since it's an array I'm not sure about my code here.

cc. @jnsdls

yes, a function MAY have multiple outputs, but usually this should be fine

github-actions · 2024-10-23T09:10:32Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.81 KB (0%)	857 ms (0%)	3.1 s (+14.66% 🔺)	3.9 s
thirdweb (cjs)	102.66 KB (0%)	2.1 s (0%)	6.8 s (-8.48% 🔽)	8.9 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	320 ms (+145.82% 🔺)	417 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	45 ms (-17.79% 🔽)	55 ms
thirdweb/react (minimal + tree-shaking)	17.33 KB (0%)	347 ms (0%)	421 ms (-60.17% 🔽)	767 ms

MananTank · 2024-10-23T14:56:32Z

apps/dashboard/src/components/contract-functions/contract-function.tsx

-            {fn.stateMutability}
-          </Badge>
+        {isFunction && <Badge variant="success">{fn.stateMutability}</Badge>}
+        {functionSelector && (


Not sure how helpful the function selector is, Deferring this to @jnsdls to decide whether this should be added or not

feels somewhat not that useful but also doesn't hurt - let's try it for a bit

jnsdls · 2024-10-23T16:34:40Z

apps/dashboard/src/components/contract-functions/contract-function.tsx

-            {fn.stateMutability}
-          </Badge>
+        {isFunction && <Badge variant="success">{fn.stateMutability}</Badge>}
+        {functionSelector && (


feels somewhat not that useful but also doesn't hurt - let's try it for a bit

jnsdls · 2024-10-23T16:35:43Z

apps/dashboard/src/components/contract-functions/interactive-abi-function.tsx

+              <div className="flex flex-row items-center gap-2">
+                <Heading size="label.sm">Output</Heading>
+                {/* Show the Solidity type of the function's output */}
+                {abiFunction.outputs.length > 0 && (


yes, a function MAY have multiple outputs, but usually this should be fine

graphite-app · 2024-10-23T18:50:19Z

Merge activity

Oct 23, 2:50 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 23, 3:01 PM EDT: A user merged this pull request with the Graphite merge queue.

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/VtULqGKSp33n0VHOzNJK/1670002e-3123-4770-b29c-fdc84dce88dd.png)

vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 09:07 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 09:07 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 09:07 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 23, 2024

kien-ngo marked this pull request as ready for review October 23, 2024 09:07

kien-ngo requested review from MananTank, jnsdls and joaquim-verges as code owners October 23, 2024 09:07

kien-ngo commented Oct 23, 2024

View reviewed changes

vercel bot deployed to Preview – thirdweb-www October 23, 2024 09:17 View deployment

MananTank reviewed Oct 23, 2024

View reviewed changes

jnsdls approved these changes Oct 23, 2024

View reviewed changes

[Dashboard] Add some informative badges to the Explorer (#5138)

4841ff3

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/VtULqGKSp33n0VHOzNJK/1670002e-3123-4770-b29c-fdc84dce88dd.png)

kien-ngo force-pushed the kien/add-badge-explorer branch from 3b5df1f to 4841ff3 Compare October 23, 2024 18:51

vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 18:51 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 18:51 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 18:51 Inactive

vercel bot deployed to Preview – thirdweb-www October 23, 2024 19:01 View deployment

graphite-app bot merged commit 4841ff3 into main Oct 23, 2024
31 checks passed

graphite-app bot deleted the kien/add-badge-explorer branch October 23, 2024 19:01

vercel bot temporarily deployed to Production – wallet-ui October 23, 2024 19:01 Inactive

vercel bot temporarily deployed to Production – docs-v2 October 23, 2024 19:01 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground October 23, 2024 19:01 Inactive

vercel bot deployed to Production – thirdweb-www October 23, 2024 19:11 View deployment

kien-ngo self-assigned this Oct 25, 2024

[Dashboard] Add some informative badges to the Explorer #5138

[Dashboard] Add some informative badges to the Explorer #5138

Conversation

kien-ngo commented Oct 23, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Oct 23, 2024

Uh oh!

codecov bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kien-ngo Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

kien-ngo Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

MananTank Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

jnsdls Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kien-ngo commented Oct 23, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 23, 2024 •

edited

Loading

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

graphite-app bot commented Oct 23, 2024 •

edited

Loading