Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating dependencies and making adjustments to the package.json files, as well as modifying the logic in the WalletImage.tsx file to handle external wallet images differently.

Detailed summary

  • Updated @mobile-wallet-protocol/client version from 0.0.3 to 0.1.1.
  • Changed logic in WalletImage.tsx to return externalWalletImage directly if it does not start with ipfs://.
  • Reformatted the files array in package.json for consistency.
  • Updated type definitions in packages/thirdweb/package.json by removing unnecessary line breaks.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 2:00am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 2:00am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 2:00am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 2:00am

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 79c5993

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/react-native-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 24, 2024 00:52
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3 s (-40% 🔽) 3.9 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 7 s (-5.31% 🔽) 9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 255 ms (+63.88% 🔺) 352 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 59 ms (-7.54% 🔽) 69 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 946 ms (+70.22% 🔺) 1.3 s

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.45%. Comparing base (9fadbcc) to head (79c5993).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5151   +/-   ##
=======================================
  Coverage   45.45%   45.45%           
=======================================
  Files        1065     1065           
  Lines       55122    55122           
  Branches     3976     3976           
=======================================
+ Hits        25053    25054    +1     
+ Misses      29377    29376    -1     
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9fadbcc
packages 40.47% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 06c0cf3 into main Oct 24, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the chore_update_mobile-wallet-protocol/client_to_0.1.1 branch October 24, 2024 08:07
@jnsdls jnsdls mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants