Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the ConnectWallet UI by implementing a consistent theme for icons, adding new icon components, and improving wallet connection options.

Detailed summary

  • Added GuestIcon, EmailIcon, FingerPrintIcon, and PhoneIcon components.
  • Updated WalletTypeRowButton to accept IconFC instead of string for icons.
  • Improved WalletAuth modal header to reflect linking status.
  • Updated social login options to use new icon components.
  • Refactored WalletImage to display icons based on authentication method.
  • Adjusted icon colors to respect the theme's accentColor.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 10:18pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 10:18pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 10:18pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 10:18pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: e8ceb2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages labels Oct 24, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 689 ms (+18.08% 🔺) 1.6 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.3 s (-9.13% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 31 ms (-29.69% 🔽) 128 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 116 ms (+1266.83% 🔺) 126 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 122 ms (+17.65% 🔺) 468 ms

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 6.33803% with 133 lines in your changes missing coverage. Please review.

Project coverage is 45.36%. Comparing base (cf36a33) to head (e8ceb2b).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...irdweb/src/react/web/ui/components/WalletImage.tsx 0.00% 32 Missing ⚠️
...src/react/web/ui/ConnectWallet/icons/PhoneIcon.tsx 7.69% 24 Missing ⚠️
...src/react/web/ui/ConnectWallet/icons/EmailIcon.tsx 8.33% 22 Missing ⚠️
...src/react/web/ui/ConnectWallet/icons/GuestIcon.tsx 11.11% 16 Missing ⚠️
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 0.00% 13 Missing ⚠️
...act/web/ui/ConnectWallet/icons/FingerPrintIcon.tsx 0.00% 9 Missing ⚠️
.../ui/ConnectWallet/screens/LinkedProfilesScreen.tsx 0.00% 7 Missing ⚠️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 6 Missing ⚠️
...t/web/ui/ConnectWallet/icons/OutlineWalletIcon.tsx 0.00% 2 Missing ⚠️
.../src/react/web/ui/ConnectWallet/WalletSelector.tsx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5163      +/-   ##
==========================================
- Coverage   45.42%   45.36%   -0.06%     
==========================================
  Files        1065     1068       +3     
  Lines       55145    55230      +85     
  Branches     3970     3970              
==========================================
+ Hits        25049    25055       +6     
- Misses      29404    29483      +79     
  Partials      692      692              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cf36a33
packages 40.38% <6.33%> (-0.07%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/thirdweb/src/react/core/utils/walletIcon.ts 57.83% <100.00%> (ø)
...dweb/src/react/web/ui/ConnectWallet/MenuButton.tsx 7.14% <ø> (+0.47%) ⬆️
.../src/react/web/ui/ConnectWallet/WalletSelector.tsx 5.57% <0.00%> (ø)
...react/web/ui/ConnectWallet/WalletTypeRowButton.tsx 9.52% <0.00%> (+2.85%) ⬆️
...t/web/ui/ConnectWallet/icons/OutlineWalletIcon.tsx 7.69% <0.00%> (ø)
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 6.93% <0.00%> (ø)
.../ui/ConnectWallet/screens/LinkedProfilesScreen.tsx 1.39% <0.00%> (-0.07%) ⬇️
...act/web/ui/ConnectWallet/icons/FingerPrintIcon.tsx 2.70% <0.00%> (ø)
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 1.34% <0.00%> (-0.11%) ⬇️
...src/react/web/ui/ConnectWallet/icons/GuestIcon.tsx 11.11% <11.11%> (ø)
... and 3 more

@joaquim-verges joaquim-verges merged commit 158c2b6 into main Oct 24, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the feat_respect_theme_accentColor_for_default_connect_UI_icons branch October 24, 2024 22:52
@jnsdls jnsdls mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants