Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 25, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on redesigning the payment selection flow for the thirdweb platform, enhancing user experience for both fiat and crypto transactions, and improving wallet selection features.

Detailed summary

  • Redesigned payment selection flow for Pay.
  • Removed the select-wallet screen from SelectedScreen type.
  • Updated TokenSymbol size options.
  • Enhanced PayEmbed with new payment options.
  • Improved PaymentSelectionScreen to manage wallet balances.
  • Refactored WalletSelectorButton to WalletRowWithBalances.
  • Updated BuyScreen to integrate new payment methods.
  • Added new components for better wallet and transaction handling.
  • Adjusted styling and layout for improved UI.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 4:09am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 4:09am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 4:09am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 4:09am

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 77ce1e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 25, 2024 11:01
Copy link
Member Author

joaquim-verges commented Oct 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 1.70455% with 346 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (2bf65c0) to head (77ce1e5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...Wallet/screens/Buy/swap/PaymentSelectionScreen.tsx 1.19% 165 Missing ⚠️
...ConnectWallet/screens/Buy/WalletSelectorButton.tsx 2.88% 101 Missing ⚠️
...i/ConnectWallet/screens/Buy/swap/PayWithCrypto.tsx 2.12% 46 Missing ⚠️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.00% 32 Missing ⚠️
...web/ui/ConnectWallet/screens/formatTokenBalance.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5176      +/-   ##
==========================================
- Coverage   45.36%   45.30%   -0.07%     
==========================================
  Files        1068     1067       -1     
  Lines       55230    55304      +74     
  Branches     3970     3970              
==========================================
- Hits        25055    25054       -1     
- Misses      29483    29557      +74     
- Partials      692      693       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2bf65c0
packages 40.31% <1.70%> (-0.07%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...allet/screens/Buy/main/useEnabledPaymentMethods.ts 5.26% <ø> (+0.26%) ⬆️
.../src/react/web/ui/components/token/TokenSymbol.tsx 5.88% <ø> (ø)
...web/ui/ConnectWallet/screens/formatTokenBalance.ts 20.00% <0.00%> (-2.23%) ⬇️
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.09% <0.00%> (+<0.01%) ⬆️
...i/ConnectWallet/screens/Buy/swap/PayWithCrypto.tsx 2.43% <2.12%> (+0.21%) ⬆️
...ConnectWallet/screens/Buy/WalletSelectorButton.tsx 2.83% <2.88%> (-1.22%) ⬇️
...Wallet/screens/Buy/swap/PaymentSelectionScreen.tsx 1.19% <1.19%> (ø)

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the feat_redesign_payment_selection_flow_for_Buy_screen branch 2 times, most recently from 0ed63f7 to cb62c1f Compare October 25, 2024 12:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 967 ms (+70.26% 🔺) 1.9 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.4 s (+15.83% 🔺) 3.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 29 ms (-28.11% 🔽) 126 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 83 ms (+224.75% 🔺) 93 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 161 ms (+60.24% 🔺) 508 ms

@joaquim-verges joaquim-verges force-pushed the feat_redesign_payment_selection_flow_for_Buy_screen branch from 54db84b to 77ce1e5 Compare October 28, 2024 03:58
@joaquim-verges joaquim-verges merged commit 84571ef into main Oct 28, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the feat_redesign_payment_selection_flow_for_Buy_screen branch October 28, 2024 07:15
@jnsdls jnsdls mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants