Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 25, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on improving the transaction handling and notification mechanism in the ClaimTabERC1155 component by replacing the useTxNotifications hook with toast.promise for better user feedback during transactions.

Detailed summary

  • Removed the useTxNotifications hook and its associated success and error handlers.
  • Introduced toast.promise for handling transaction approval and NFT claiming, providing feedback on loading, success, and error states.
  • Added error logging with console.error for failed transactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:21pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 25, 2024 5:21pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 25, 2024 5:21pm
wallet-ui ⬜️ Skipped (Inspect) Oct 25, 2024 5:21pm

@linear
Copy link

linear bot commented Oct 25, 2024

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 25, 2024 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 25, 2024 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 25, 2024 16:58 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 4cb7f8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review October 25, 2024 16:58
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 25, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 2.8 s (-12.38% 🔽) 3.7 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 7.2 s (+14.61% 🔺) 9.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 288 ms (+83.46% 🔺) 385 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 139 ms (-33.05% 🔽) 149 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 752 ms (+33.63% 🔺) 1.1 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ClaimTabERC1155` component by removing the `useTxNotifications` hook and replacing success/error handling with `toast.promise`. This improves user feedback during transaction processes.

### Detailed summary
- Removed the `useTxNotifications` hook and its related success/error callbacks.
- Introduced `toast.promise` for handling promises related to approving ERC20 tokens and claiming NFTs.
- Improved error handling with `console.error` for better debugging.
- Updated success/error messages for user feedback.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 25, 2024 17:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 25, 2024 17:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 25, 2024 17:11 Inactive
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (9dfe4af) to head (4cb7f8f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5177   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3970     3970           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9dfe4af
packages 40.38% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app graphite-app bot merged commit 4cb7f8f into main Oct 25, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/dash-347 branch October 25, 2024 17:21
@vercel vercel bot temporarily deployed to Production – wallet-ui October 25, 2024 17:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 25, 2024 17:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 25, 2024 17:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants