-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] DASH-347 | Claim issue with EditionDrop #5177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `ClaimTabERC1155` component by removing the `useTxNotifications` hook and replacing success/error handling with `toast.promise`. This improves user feedback during transaction processes.
### Detailed summary
- Removed the `useTxNotifications` hook and its related success/error callbacks.
- Introduced `toast.promise` for handling promises related to approving ERC20 tokens and claiming NFTs.
- Improved error handling with `console.error` for better debugging.
- Updated success/error messages for user feedback.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
fbca13e to
4cb7f8f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5177 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1068 1068
Lines 55230 55230
Branches 3970 3970
=======================================
Hits 25055 25055
Misses 29483 29483
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the transaction handling and notification mechanism in the
ClaimTabERC1155component by replacing theuseTxNotificationshook withtoast.promisefor better user feedback during transactions.Detailed summary
useTxNotificationshook and its associated success and error handlers.toast.promisefor handling transaction approval and NFT claiming, providing feedback on loading, success, and error states.console.errorfor failed transactions.