-
Notifications
You must be signed in to change notification settings - Fork 619
Project showcase patches #5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project showcase patches #5178
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5178 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1068 1068
Lines 55230 55230
Branches 3970 3970
=======================================
Hits 25055 25055
Misses 29483 29483
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
|
Feel free to yell at me later, but due to time constraints and the minor nature of this change, going to merge this in. All tests + CI have passed. Will all be converted to framer as a next step |
Problem solved
Primarily moves the files from (dashboard) out to (apps), also added hero section back
PR-Codex overview
This PR focuses on refactoring the import paths in the
page.tsxfiles for theproject-showcasefeature and updating the hero section layout in theProjectShowcasePagecomponent.Detailed summary
apps/dashboard/src/app/(dashboard)/project-showcase/[slug]/page.tsxandapps/dashboard/src/app/project-showcase/page.tsx.<Image>component with<img>in both files, adding an ESLint disable comment.ProjectShowcasePagewith new structure and content.<Link>components for "Get Started" and "View all case studies".