Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 25, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating dependencies and improving the error messaging in the errorParser.tsx file. It upgrades the @sentry/nextjs package and refines the way error messages are displayed in the application.

Detailed summary

  • Updated @sentry/nextjs from 8.34.0 to 8.35.0.
  • Changed the error message component from <Text> to <span> for PLEASE_REACH_OUT_MESSAGE.
  • Updated the class from font-bold to font-semibold for the <Link> inside PLEASE_REACH_OUT_MESSAGE.
  • Adjusted the main message display to use <span> with line-clamp-3 class for better formatting.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:41pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:41pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:41pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 5:41pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 63bbb4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 25, 2024
@MananTank MananTank changed the title Fix page crash when calling from on pages without ChakraProvider, restore latest sentry version Fix page crash when calling onError from on pages without ChakraProvider, restore latest sentry version Oct 25, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank changed the title Fix page crash when calling onError from on pages without ChakraProvider, restore latest sentry version Fix page crash when using useTxNotifications on pages without ChakraProvider, restore latest sentry version Oct 25, 2024
@MananTank MananTank marked this pull request as ready for review October 25, 2024 17:28
@socket-security
Copy link

socket-security bot commented Oct 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sentry/[email protected] environment, filesystem, network Transitive: eval, shell, unsafe +265 63.9 MB sentry-bot

🚮 Removed packages: npm/@sentry/[email protected]

View full report↗︎

@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (4cb7f8f) to head (63bbb4c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5179   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3970     3970           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4cb7f8f
packages 40.38% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.3 s (+54.72% 🔺) 4.2 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 8 s (+17.99% 🔺) 10.1 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 478 ms (-17.7% 🔽) 575 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 169 ms (+219.92% 🔺) 179 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 894 ms (+158.9% 🔺) 1.3 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Merge activity

…rovider, restore latest sentry version (#5179)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating dependencies and modifying the error message presentation in the `errorParser.tsx` file. It upgrades several `@sentry` packages and refines the structure of the error messages displayed to users.

### Detailed summary
- Updated `@sentry/nextjs` from `8.34.0` to `8.35.0`.
- Changed the `PLEASE_REACH_OUT_MESSAGE` structure from using `<Text>` to a `<span>`.
- Updated the class name for the `<Link>` from `font-bold` to `font-semibold`.
- Modified error message rendering in `parseErrorToMessage` to use `<span>` instead of `<Text>`.
- Updated several `@sentry` internal dependencies to version `8.35.0` across `pnpm-lock.yaml`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants