Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 25, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR modifies the layout.tsx file to enhance the contract validation logic by including a check for the localhost chain ID before verifying if a contract is deployed. This helps prevent unnecessary contract checks for local development environments.

Detailed summary

  • Added an import for localhost from thirdweb/chains.
  • Wrapped the contract existence check in a condition to only execute if the contract.chain.id is not localhost.id.
  • Maintained the existing logic for handling invalid contracts and the notFound function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:10pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 25, 2024 6:10pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 25, 2024 6:10pm
wallet-ui ⬜️ Skipped (Inspect) Oct 25, 2024 6:10pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 25, 2024 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 25, 2024 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 25, 2024 18:00 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 551e9bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 25, 2024 18:00
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 25, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (4ec2aa8) to head (551e9bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5180   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3970     3970           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4ec2aa8
packages 40.38% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 228 ms (+31.72% 🔺) 1.1 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 593 ms (+3.92% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 120 ms (+380.3% 🔺) 217 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 37 ms (+455.64% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 112 ms (+130.9% 🔺) 458 ms

@MananTank MananTank closed this Oct 25, 2024
@MananTank MananTank deleted the 10-25-remove_isvalidcontract_check_for_localhost_chain_on_contract_page branch December 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants