-
Notifications
You must be signed in to change notification settings - Fork 619
Remove isValidContract check for localhost chain on contract page #5180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isValidContract check for localhost chain on contract page #5180
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5180 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1068 1068
Lines 55230 55230
Branches 3970 3970
=======================================
Hits 25055 25055
Misses 29483 29483
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR modifies the
layout.tsxfile to enhance the contract validation logic by including a check for thelocalhostchain ID before verifying if a contract is deployed. This helps prevent unnecessary contract checks for local development environments.Detailed summary
localhostfromthirdweb/chains.contract.chain.idis notlocalhost.id.notFoundfunction.