Skip to content

Conversation

@edwardysun
Copy link
Contributor

@edwardysun edwardysun commented Oct 25, 2024

Should have done this in framer, this will be the last commit of the hackathon


PR-Codex overview

This PR focuses on enhancing the ProjectShowcasePage by improving the structure of project links and adding a Button component for case studies.

Detailed summary

  • Added import for Button from the UI components.
  • Changed the outer Link to a div for better structure.
  • Wrapped the Card in a Link for clickable navigation.
  • Added a Button for case studies, with conditional rendering.
  • Improved layout and organization of project details.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: da6990f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:44pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 25, 2024 6:44pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 25, 2024 6:44pm
wallet-ui ⬜️ Skipped (Inspect) Oct 25, 2024 6:44pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 25, 2024
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (4ec2aa8) to head (da6990f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5181   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3970     3970           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from de1a8ad
packages 40.38% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 4.1 s (-6.71% 🔽) 5 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 5.9 s (-22.95% 🔽) 8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 591 ms (+244.28% 🔺) 688 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 52 ms (-28.8% 🔽) 62 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 1.5 s (+187.42% 🔺) 1.9 s

@edwardysun
Copy link
Contributor Author

Feel free to yell at me later, but due to time constraints and the minor nature of this change (primarily moving files from one directory to the other + cosmetic changes), going to merge this in. All tests + CI have passed. Will all be converted to framer as a next step

@edwardysun edwardysun merged commit 363b633 into main Oct 25, 2024
30 checks passed
@edwardysun edwardysun deleted the project-showcase-case-study-button branch October 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants