-
Notifications
You must be signed in to change notification settings - Fork 619
Fix op estimation edge case #5184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generally verificationGas is not a thing, but just in case it is with some bundlers, making it optional so it doesn't throw "Cannot convert undefined to a BigInt"
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5184 +/- ##
==========================================
- Coverage 45.36% 45.36% -0.01%
==========================================
Files 1068 1068
Lines 55230 55233 +3
Branches 3970 3971 +1
==========================================
Hits 25055 25055
- Misses 29483 29486 +3
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more.
|
Problem solved
Generally verificationGas is not a thing, but just in case it is with some bundlers, making it optional so it doesn't throw "Cannot convert undefined to a BigInt"
PR-Codex overview
This PR modifies the
EstimationResulttype and its usage in thebundler.tsfile to make theverificationGasproperty optional. This change allows for better handling of cases whereverificationGasmay not be present.Detailed summary
types.ts, changedverificationGasfrom a required property to an optional property (verificationGas?: bigint).bundler.ts, updated the return statement to check ifres.verificationGasis defined before converting it withhexToBigInt, returningundefinedif not present.