Fixed a redundant return statement in isLoggedIn() & a typo #5194
Conversation
Fixed a redundant return statement in `isLoggedIn()` method from:
```
if (!authResult.valid) {
return false;
}
return true;
```
To simply:
```
return authResult.valid;
```
Signed-off-by: Captain Unknown <[email protected]>
CaptainUnknown
requested review from
MananTank,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
@CaptainUnknown is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
Portal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 participants
Removed Redundant Return: Removed the redundant return statements in
isLoggedIn()method for server-side setup. It now simply returnsauthResult.valid.From:
To:
Fixed Typo: Corrected "know" to "now" in the text.
PR-Codex overview
This PR simplifies the authentication check in the
AuthenticatedPagecomponent by directly returning the validity of theauthResult. It also corrects a typo in the documentation.Detailed summary
authResult.validwith a direct return statement:return authResult.valid;