Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 28, 2024

PR-Codex overview

This PR focuses on updating the documentation and settings for the Unity SDK, specifically around the Thirdweb Manager. It includes the addition of new build instructions, updates to social login options, and the removal of an image, while also improving the sidebar navigation.

Detailed summary

  • Removed thirdwebmanager.png image.
  • Updated title in page.mdx from "Unity SDK (v5)" to "Unity SDK".
  • Expanded social login options to include Github and Twitch.
  • Added a new section for Build Instructions with detailed settings.
  • Updated sidebar to include "Build Instructions" and "Migrate from v4".
  • Revised image imports in thirdwebmanager/page.mdx to use new images.
  • Enhanced configuration sections for Client, Preferences, and Misc.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: fb5115a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 9:39pm
thirdweb-www ⬜️ Skipped (Inspect) Oct 28, 2024 9:39pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 9:39pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 28, 2024
@0xFirekeeper 0xFirekeeper added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.3 s (+64.15% 🔺) 4.2 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 7.6 s (-6.98% 🔽) 9.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 211 ms (-5.38% 🔽) 307 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 72 ms (-62.48% 🔽) 82 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 761 ms (+3.78% 🔺) 1.2 s

@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (a5ffc54) to head (fb5115a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5195   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a5ffc54
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Member Author

0xFirekeeper commented Oct 28, 2024

Merge activity

  • Oct 28, 2:56 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 28, 5:18 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 28, 5:31 PM EDT: A user merged this pull request with the Graphite merge queue.

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on updating the documentation for the `Unity SDK`, including changes to wallet options, sidebar navigation, and the introduction of build instructions. It also replaces an image and adds new sections for configuration and debugging.

### Detailed summary
- Removed `thirdwebmanager.png` and updated image imports.
- Changed title in `page.mdx` from "Unity SDK (v5)" to "Unity SDK".
- Expanded wallet options to include `Github` and `Twitch`.
- Added new `Build Instructions` section in `page.mdx`.
- Updated sidebar to include `Build Instructions` and `Migrate from v4`.
- Revised `Client Settings` and added `Preferences`, `Misc`, and `Debug` sections.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@0xFirekeeper 0xFirekeeper force-pushed the firekeeper/docs-unity-5.7.0 branch from 91390f2 to fb5115a Compare October 28, 2024 21:28
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 21:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 28, 2024 21:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 21:28 Inactive
@graphite-app graphite-app bot merged commit fb5115a into main Oct 28, 2024
29 of 30 checks passed
@graphite-app graphite-app bot deleted the firekeeper/docs-unity-5.7.0 branch October 28, 2024 21:31
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 21:31 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 21:31 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 28, 2024 21:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants