Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Oct 28, 2024

PR-Codex overview

This PR focuses on refactoring the message validation process by removing the CoinbaseKit dependency and introducing utility functions from lib/farcaster-frames. It enhances code clarity and maintainability by centralizing frame message validation and account address retrieval.

Detailed summary

  • Deleted farcaster.ts and CoinbaseKit.ts files.
  • Added validateFrameMessage and getFarcasterAccountAddress functions in lib/farcaster-frames.ts.
  • Replaced CoinbaseKit.validateMessage calls with validateFrameMessage in several API handler files.
  • Updated JSON body parsing to remove type assertion for FrameRequest.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jnsdls jnsdls mentioned this pull request Oct 28, 2024
@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: ddec3da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 11:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 11:39pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 11:39pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 11:39pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 23:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 23:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 23:01 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2024
Copy link
Member Author

jnsdls commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@jnsdls jnsdls marked this pull request as ready for review October 28, 2024 23:01
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 3 s (-13.83% 🔽) 3.9 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 6.6 s (+12.38% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 151 ms (-34.06% 🔽) 247 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 39 ms (-63.06% 🔽) 49 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 909 ms (+178.07% 🔺) 1.3 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Merge activity

@jnsdls jnsdls force-pushed the 10-28-update_dependencies branch from 780d79b to ac78881 Compare October 28, 2024 23:25
@jnsdls jnsdls force-pushed the Refactor_Farcaster_frame_validation branch from 9a955d2 to ddec3da Compare October 28, 2024 23:25
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 23:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 23:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 23:25 Inactive
Base automatically changed from 10-28-update_dependencies to main October 28, 2024 23:37
@graphite-app graphite-app bot merged commit ddec3da into main Oct 28, 2024
26 checks passed
@graphite-app graphite-app bot deleted the Refactor_Farcaster_frame_validation branch October 28, 2024 23:39
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 23:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 23:39 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 23:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 28, 2024 23:42 Inactive
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.26%. Comparing base (ac78881) to head (ddec3da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5211   +/-   ##
=======================================
  Coverage   45.26%   45.26%           
=======================================
  Files        1067     1067           
  Lines       55347    55347           
  Branches     3971     3971           
=======================================
  Hits        25054    25054           
  Misses      29601    29601           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ac78881
packages 40.27% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants