-
Notifications
You must be signed in to change notification settings - Fork 619
Refactor Farcaster frame validation #5211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Merge activity
|
780d79b to
ac78881
Compare
9a955d2 to
ddec3da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5211 +/- ##
=======================================
Coverage 45.26% 45.26%
=======================================
Files 1067 1067
Lines 55347 55347
Branches 3971 3971
=======================================
Hits 25054 25054
Misses 29601 29601
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |

PR-Codex overview
This PR focuses on refactoring the message validation process by removing the
CoinbaseKitdependency and introducing utility functions fromlib/farcaster-frames. It enhances code clarity and maintainability by centralizing frame message validation and account address retrieval.Detailed summary
farcaster.tsandCoinbaseKit.tsfiles.validateFrameMessageandgetFarcasterAccountAddressfunctions inlib/farcaster-frames.ts.CoinbaseKit.validateMessagecalls withvalidateFrameMessagein several API handler files.FrameRequest.