Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 29, 2024

Problem solved

CNCT-2186


PR-Codex overview

This PR focuses on enhancing the wallet migration process within the thirdweb package, specifically transitioning in-app wallets to a new enclave system, improving error handling, and refining wallet initialization logic.

Detailed summary

  • Added automatic migration for in-app wallets to the new enclave system.
  • Improved error handling in PassKeyLogin.tsx by logging errors.
  • Simplified condition for wallet generation in iframe-auth.ts.
  • Enhanced wallet migration logic in native-connector.ts with error logging.
  • Refined wallet initialization process in web-connector.ts, ensuring proper handling of wallet types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:52am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:52am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:52am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:52am

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 0cc8b40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 29, 2024 07:34
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 205 ms (+40.73% 🔺) 1.1 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 292 ms (+1.33% 🔺) 2.4 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 28 ms (-6.58% 🔽) 125 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 29 ms (+217.65% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 155 ms (+307.33% 🔺) 505 ms

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (9fb2a71) to head (0cc8b40).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 0.00% 12 Missing ⚠️
...dweb/src/react/web/wallets/shared/PassKeyLogin.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5217      +/-   ##
==========================================
- Coverage   45.61%   45.61%   -0.01%     
==========================================
  Files        1068     1068              
  Lines       55556    55557       +1     
  Branches     4047     4045       -2     
==========================================
  Hits        25341    25341              
- Misses      29525    29526       +1     
  Partials      690      690              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9fb2a71
packages 40.72% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...dweb/src/react/web/wallets/shared/PassKeyLogin.tsx 0.88% <0.00%> (-0.01%) ⬇️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 0.28% <0.00%> (ø)

@joaquim-verges joaquim-verges removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 6, 2024
@joaquim-verges joaquim-verges merged commit b633293 into main Nov 6, 2024
31 of 33 checks passed
@joaquim-verges joaquim-verges deleted the feat_auto-migrate_in-app_wallets_to_enclave_system branch November 6, 2024 06:12
@jnsdls jnsdls mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants