-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Fix contract source code page #5218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5218 +/- ##
==========================================
- Coverage 45.32% 45.29% -0.03%
==========================================
Files 1067 1067
Lines 55245 55341 +96
Branches 3969 3973 +4
==========================================
+ Hits 25039 25068 +29
- Misses 29514 29581 +67
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR updates the error handling for resolving the contract ABI in the `page.tsx` file by changing the promise handling from `then` to `catch`, ensuring that any errors in resolving the ABI will result in `undefined` being assigned.
### Detailed summary
- Changed the promise handling for `resolveContractAbi(contract)`:
- From using `.then(() => undefined)` to `.catch(() => undefined)` to properly handle errors.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
2447d20 to
c8b5780
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR updates the error handling in the
page.tsxfile for theabivariable assignment, ensuring that ifresolveContractAbi(contract)fails, it will returnundefinedinstead of potentially throwing an error.Detailed summary
abifrom using.then()to.catch()for error handling.resolveContractAbi(contract)fails,abiwill be set toundefined.