Skip to content

[Dashboard] Fix contract source code page #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

[Dashboard] Fix contract source code page #5218

merged 1 commit into from
Oct 29, 2024

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 29, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the error handling in the page.tsx file for the abi variable assignment, ensuring that if resolveContractAbi(contract) fails, it will return undefined instead of potentially throwing an error.

Detailed summary

  • Changed the assignment of abi from using .then() to .catch() for error handling.
  • Ensures that if resolveContractAbi(contract) fails, abi will be set to undefined.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c8b5780

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 3:04pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 29, 2024 3:04pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 29, 2024 3:04pm
wallet-ui ⬜️ Skipped (Inspect) Oct 29, 2024 3:04pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 29, 2024 14:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 29, 2024 14:08 Inactive
@kien-ngo kien-ngo marked this pull request as ready for review October 29, 2024 14:08
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 29, 2024 14:08 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 29, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Oct 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (68ce724) to head (c8b5780).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5218      +/-   ##
==========================================
- Coverage   45.32%   45.29%   -0.03%     
==========================================
  Files        1067     1067              
  Lines       55245    55341      +96     
  Branches     3969     3973       +4     
==========================================
+ Hits        25039    25068      +29     
- Misses      29514    29581      +67     
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 68ce724
packages 40.30% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 476 ms (+7.89% 🔺) 1.4 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 790 ms (-23.24% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 82 ms (+384% 🔺) 179 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 10 ms (+45.35% 🔺) 20 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 107 ms (+79.1% 🔺) 455 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2024 •
edited
Loading

Merge activity

@kien-ngo
[Dashboard] Fix contract source code page (#5218)
c8b5780 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the error handling for resolving the contract ABI in the `page.tsx` file by changing the promise handling from `then` to `catch`, ensuring that any errors in resolving the ABI will result in `undefined` being assigned.

### Detailed summary
- Changed the promise handling for `resolveContractAbi(contract)`:
  - From using `.then(() => undefined)` to `.catch(() => undefined)` to properly handle errors.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/fix-contract-code-page branch from 2447d20 to c8b5780 Compare October 29, 2024 15:01
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 29, 2024 15:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 29, 2024 15:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 29, 2024 15:01 Inactive
@graphite-app graphite-app bot merged commit c8b5780 into main Oct 29, 2024
30 checks passed
@graphite-app graphite-app bot deleted the kien/fix-contract-code-page branch October 29, 2024 15:04
@vercel vercel bot temporarily deployed to Production – docs-v2 October 29, 2024 15:04 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 29, 2024 15:04 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 29, 2024 15:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kien-ngo @MananTank