[Dashboard] Improve faucet claim #5226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5226 +/- ##
=======================================
Coverage 45.59% 45.59%
=======================================
Files 1069 1069
Lines 55584 55584
Branches 4045 4045
=======================================
Hits 25342 25342
Misses 29552 29552
Partials 690 690
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/improve-faucet-claim
branch
from
89a6e1c to
a172405
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kien-ngo
force-pushed
the
kien/improve-faucet-claim
branch
from
a172405 to
462db2a
Compare
kien-ngo
force-pushed
the
kien/improve-faucet-claim
branch
from
462db2a to
d08e0d0
Compare
...hboard/src/app/(dashboard)/(chain)/[chain_id]/(chainPage)/components/client/FaucetButton.tsx
Outdated
Show resolved
Hide resolved
kien-ngo
force-pushed
the
kien/improve-faucet-claim
branch
from
225ed27 to
c21c7e6
Compare
kien-ngo
force-pushed
the
kien/improve-faucet-claim
branch
from
c21c7e6 to
46f31b0
Compare
MananTank
force-pushed
the
kien/improve-faucet-claim
branch
from
46f31b0 to
0d68199
Compare
MananTank
approved these changes
Nov 5, 2024
jnsdls
approved these changes
Nov 5, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the functionality of the `Faucet` feature in the dashboard application. It introduces new environment variables, updates modal components to allow for state management, and improves API endpoints for better user authentication and request handling.
### Detailed summary
- Added `REDIS_URL` and updated `TURNSTILE_SECRET_KEY` in `.env.example`.
- Updated `turbo.json` to include new environment variables.
- Modified `OnboardingModal` to accept `onOpenChange` prop for state management.
- Enhanced API routes to check for email verification before allowing faucet claims.
- Improved error handling for wallet connections and request limits.
- Updated `FaucetButton` to show onboarding modal for email verification.
- Added caching logic for user requests to prevent abuse.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
kien/improve-faucet-claim
branch
from
0d68199 to
43b7c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the functionality of the
Faucetfeature in the dashboard application. It introduces new environment variables, updates modal components to allow closing, and modifies API routes to ensure email verification for faucet claims.Detailed summary
REDIS_URLto.env.example.turbo.jsonto include new environment variables.OnboardingModalto acceptonOpenChangeprop.FaucetButtonto handle email verification.