Winston/don't use iframe for jwt or custom auth endpoint validation #5229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9425e9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5229 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 1067 1067
Lines 55341 55339 -2
Branches 3973 3973
=======================================
Hits 25068 25068
+ Misses 29581 29579 -2
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more.
|
ElasticBottle
changed the title
joaquim-verges
approved these changes
Oct 30, 2024
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
…5229) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR consolidates authentication methods in the `thirdweb` package by introducing a common endpoint for custom JWT and custom auth, enhancing code organization and reducing redundancy. ### Detailed summary - Changed `getSessionHeaders` to no longer export it. - Introduced `ecosystem` parameter in various functions. - Replaced direct `fetch` calls with `getClientFetch` for consistency. - Simplified the `loginWithAuthToken` method to accept an optional `recoveryCode`. - Unified handling of authentication strategies in `InAppWebConnector`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/don't-use-iframe-for-custom-auth-/-jwt-auth
branch
from
49bbbaf to
9425e9e
Compare
graphite-app
bot
deleted the
winston/don't-use-iframe-for-custom-auth-/-jwt-auth
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR consolidates the custom JWT and custom authentication endpoint into a common endpoint, streamlining the authentication process in the
thirdwebpackage.Detailed summary
getSessionHeadersfunction export infetchers.ts.native-connector.tsto includeecosystemin authentication payloads.guest.tsfor clarity.getClientFetchinjwt.tsandauthEndpoint.ts.ecosystemparameter tocustomJwtandauthEndpointfunctions.InAppWebConnectorto handlerecoveryCodeinloginWithAuthToken.