Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 30, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the predictSmartAccountAddress function to support custom bundler URLs and improve user experience. It also updates related tests and documentation to reflect these changes.

Detailed summary

  • Added bundlerUrl and entrypointAddress to the user operation options.
  • Renamed predictAddress to predictSmartAccountAddress in several files.
  • Implemented predictSmartAccountAddress function with parameters for client, chain, adminAddress, and optional factoryAddress and accountSalt.
  • Updated tests to include assertions for predictSmartAccountAddress.
  • Enhanced documentation with examples for using predictSmartAccountAddress.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:32am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:32am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:32am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:32am

@joaquim-verges joaquim-verges marked this pull request as ready for review October 30, 2024 08:38
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 755 ms (-23.66% 🔽) 1.7 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 1.7 s (-3.93% 🔽) 3.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 81 ms (+135.34% 🔺) 178 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 63 ms (+392.16% 🔺) 73 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 320 ms (+32.12% 🔺) 668 ms

@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (49bbbaf) to head (a8cff3d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5231      +/-   ##
==========================================
- Coverage   45.29%   45.29%   -0.01%     
==========================================
  Files        1067     1068       +1     
  Lines       55339    55380      +41     
  Branches     3973     3975       +2     
==========================================
+ Hits        25068    25082      +14     
- Misses      29579    29606      +27     
  Partials      692      692              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 556e113
packages 40.30% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../thirdweb/src/transaction/prepare-contract-call.ts 90.47% <ø> (ø)
packages/thirdweb/src/wallets/smart/lib/calls.ts 71.28% <100.00%> (+3.87%) ⬆️
packages/thirdweb/src/wallets/smart/lib/userop.ts 66.79% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: a8cff3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 30, 2024
@joaquim-verges joaquim-verges deleted the feat_respect_custom_bundler_URL_for_gas_fees branch October 30, 2024 10:14
@jnsdls jnsdls mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants