Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 30, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the in-app wallets feature, enhancing analytics, and integrating new components for better tracking and user experience. It involves code cleanup, improved data handling, and the addition of new constants and UI elements.

Detailed summary

  • Deleted AnalyticsCallout component from various files.
  • Introduced TRACKING_CATEGORY constants for better analytics tracking.
  • Updated Page components to use new InAppWalletUsersPageContent and InAppWalletSettingsPage.
  • Enhanced analytics with new functions for fetching wallet usage data.
  • Improved UI elements for better user interaction and visibility of analytics.
  • Added InAppWalletsSummary component for displaying wallet statistics.
  • Updated chart components to format data more effectively.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:15am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 30, 2024 10:15am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 30, 2024 10:15am
wallet-ui ⬜️ Skipped (Inspect) Oct 30, 2024 10:15am

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 09:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 09:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 09:15 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: aedaa10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 30, 2024
@joaquim-verges joaquim-verges changed the title [Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) (#5227) [Dashboard] Feature: Adds analytics to in-app-wallets page Oct 30, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title [Dashboard] Feature: Adds analytics to in-app-wallets page feat(dashboard): Adds analytics to in-app-wallets page Oct 30, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review October 30, 2024 09:16
@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (49bbbaf) to head (aedaa10).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5232   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1067     1067           
  Lines       55339    55339           
  Branches     3973     3973           
=======================================
  Hits        25068    25068           
  Misses      29579    29579           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 556e113
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 2.9 s (+25.78% 🔺) 3.8 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 6.6 s (-13.16% 🔽) 8.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 284 ms (-53.46% 🔽) 380 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 96 ms (+27.47% 🔺) 106 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 780 ms (+49.83% 🔺) 1.2 s

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 30, 2024 10:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 30, 2024 10:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 30, 2024 10:05 Inactive
@joaquim-verges joaquim-verges merged commit 950ce60 into main Oct 30, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/stats-2 branch October 30, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants