Fix theming class hydration warning on html element #5233

MananTank · 2024-10-30T13:10:33Z

This is the correct way to fix this
https://github.com/pacocoursey/next-themes?tab=readme-ov-file#with-app

suppressHydrationWarning property only applies one level deep, so it won't block hydration warnings on other child elements of <html>

PR-Codex overview

This PR focuses on adding the suppressHydrationWarning attribute to the <html> tag in multiple layout files to prevent hydration warnings in React applications.

Detailed summary

Added suppressHydrationWarning to <html lang="en"> in:
- apps/portal/src/app/layout.tsx
- apps/dashboard/src/app/layout.tsx
- apps/playground-web/src/app/layout.tsx
- apps/wallet-ui/src/app/layout.tsx
- apps/dashboard/src/app/global-error.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-30T13:10:36Z

⚠️ No Changeset found

Latest commit: 2a817eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-30T13:10:37Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel · 2024-10-30T13:10:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 4:39pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 4:39pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 4:39pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 4:39pm

MananTank · 2024-10-30T13:10:50Z

Fix enum lint warning in dashboard #5234
Fix theming class hydration warning on html element #5233 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

codecov · 2024-10-30T13:12:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (686d0c3) to head (3658b3f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5233   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1068     1068           
  Lines       55380    55380           
  Branches     3975     3975           
=======================================
  Hits        25082    25082           
  Misses      29606    29606           
  Partials      692      692

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 686d0c3
packages	`40.30% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-10-30T13:14:03Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43 KB (0%)	861 ms (0%)	5.8 s (+66.01% 🔺)	6.7 s
thirdweb (cjs)	102.91 KB (0%)	2.1 s (0%)	6.2 s (-0.26% 🔽)	8.3 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	179 ms (+22.06% 🔺)	276 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	48 ms (-46.6% 🔽)	58 ms
thirdweb/react (minimal + tree-shaking)	17.38 KB (0%)	348 ms (0%)	1.6 s (+112.67% 🔺)	1.9 s

graphite-app · 2024-10-30T16:35:15Z

Merge activity

Oct 30, 12:35 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 30, 12:39 PM EDT: A user merged this pull request with the Graphite merge queue.

This is the correct way to fix this https://github.com/pacocoursey/next-themes?tab=readme-ov-file#with-app ` suppressHydrationWarning` property only applies one level deep, so it won't block hydration warnings on other child elements of `<html>`

github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. labels Oct 30, 2024

MananTank marked this pull request as ready for review October 30, 2024 13:11

MananTank requested review from gregfromstl, jnsdls and joaquim-verges as code owners October 30, 2024 13:11

vercel bot deployed to Preview – thirdweb_playground October 30, 2024 13:12 View deployment

vercel bot deployed to Preview – wallet-ui October 30, 2024 13:13 View deployment

vercel bot deployed to Preview – thirdweb-www October 30, 2024 13:21 View deployment

vercel bot deployed to Preview – docs-v2 October 30, 2024 13:23 View deployment

MananTank mentioned this pull request Oct 30, 2024

Fix enum lint warning in dashboard #5234

Merged

jnsdls approved these changes Oct 30, 2024

View reviewed changes

MananTank force-pushed the 10-30-fix_theming_class_hydration_warning_on_html_element branch from 2a817eb to 3658b3f Compare October 30, 2024 16:35

vercel bot deployed to Preview – wallet-ui October 30, 2024 16:36 View deployment

vercel bot deployed to Preview – thirdweb_playground October 30, 2024 16:37 View deployment

vercel bot deployed to Preview – thirdweb-www October 30, 2024 16:38 View deployment

vercel bot deployed to Preview – docs-v2 October 30, 2024 16:39 View deployment

graphite-app bot merged commit 3658b3f into main Oct 30, 2024
30 checks passed

graphite-app bot deleted the 10-30-fix_theming_class_hydration_warning_on_html_element branch October 30, 2024 16:39

vercel bot deployed to Production – wallet-ui October 30, 2024 16:41 View deployment

vercel bot deployed to Production – thirdweb_playground October 30, 2024 16:41 View deployment

vercel bot deployed to Production – docs-v2 October 30, 2024 16:42 View deployment

vercel bot deployed to Production – thirdweb-www October 30, 2024 16:49 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix theming class hydration warning on html element #5233

Fix theming class hydration warning on html element #5233

Uh oh!

MananTank commented Oct 30, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 30, 2024

Uh oh!

graphite-app bot commented Oct 30, 2024

Uh oh!

vercel bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

MananTank commented Oct 30, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix theming class hydration warning on html element #5233

Fix theming class hydration warning on html element #5233

Uh oh!

Conversation

MananTank commented Oct 30, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

vercel bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 30, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 30, 2024 •

edited

Loading

MananTank commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading

graphite-app bot commented Oct 30, 2024 •

edited

Loading