Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 30, 2024

Problem solved

Fixes #5225


PR-Codex overview

This PR focuses on sanitizing block explorer URLs by introducing utility functions for formatting transaction and address URLs. This ensures consistent URL construction across various components in the thirdweb package.

Detailed summary

  • Added formatExplorerTxUrl function to format transaction URLs.
  • Added formatExplorerAddressUrl function to format address URLs.
  • Refactored multiple components to use the new URL formatting functions:
    • FiatTxDetailsTable.tsx
    • WalletTransactionHistory.tsx
    • TransactionsScreen.tsx
    • ExecutingScreen.tsx
    • FiatSteps.tsx
    • SwapDetailsScreen.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 5e9a11c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:15pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:15pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:15pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:15pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@sentry
Copy link

sentry bot commented Oct 30, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/thirdweb/src/react/web/ui/ConnectWallet/TransactionsScreen.tsx

Function Unhandled Issue
TransactionsScreen TypeError: Cannot read properties of undefined (reading 'call') incomplete-app-rou...
Event Count: 1 Affected Users: 4

Did you find this useful? React with a 👍 or 👎

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 4 s (+37.83% 🔺) 4.9 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 6.3 s (-2.62% 🔽) 8.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 243 ms (-19.28% 🔽) 340 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 85 ms (+41.7% 🔺) 95 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 553 ms (-19.5% 🔽) 901 ms

@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (950ce60) to head (5e9a11c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...screens/Buy/pay-transactions/SwapDetailsScreen.tsx 0.00% 12 Missing ⚠️
...eb/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx 0.00% 8 Missing ⚠️
.../react/web/ui/ConnectWallet/TransactionsScreen.tsx 0.00% 4 Missing ⚠️
...nectWallet/screens/Buy/fiat/FiatTxDetailsTable.tsx 0.00% 4 Missing ⚠️
...react/web/ui/TransactionButton/ExecutingScreen.tsx 0.00% 4 Missing ⚠️
...ConnectWallet/screens/WalletTransactionHistory.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5237   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1068     1067    -1     
  Lines       55380    55374    -6     
  Branches     3975     3978    +3     
=======================================
- Hits        25082    25081    -1     
+ Misses      29606    29601    -5     
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 950ce60
packages 40.30% <0.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ConnectWallet/screens/WalletTransactionHistory.tsx 1.94% <0.00%> (ø)
.../react/web/ui/ConnectWallet/TransactionsScreen.tsx 2.08% <0.00%> (-0.07%) ⬇️
...nectWallet/screens/Buy/fiat/FiatTxDetailsTable.tsx 2.35% <0.00%> (-0.03%) ⬇️
...react/web/ui/TransactionButton/ExecutingScreen.tsx 2.17% <0.00%> (-0.08%) ⬇️
...eb/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx 0.67% <0.00%> (-0.01%) ⬇️
...screens/Buy/pay-transactions/SwapDetailsScreen.tsx 1.13% <0.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 802d3bf into main Oct 30, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the fix_sanitize_block_explorer_URLs branch October 30, 2024 23:37
@jnsdls jnsdls mentioned this pull request Oct 30, 2024
jnsdls pushed a commit that referenced this pull request Nov 1, 2024
jnsdls pushed a commit that referenced this pull request Nov 5, 2024
jnsdls pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transactions block explorer links navigate to 404 page on Treasure Topaz network

2 participants