-
Notifications
You must be signed in to change notification settings - Fork 619
fix: sanitize block explorer URLs #5237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5e9a11c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: packages/thirdweb/src/react/web/ui/ConnectWallet/TransactionsScreen.tsx
Did you find this useful? React with a 👍 or 👎 |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 1068 1067 -1
Lines 55380 55374 -6
Branches 3975 3978 +3
=======================================
- Hits 25082 25081 -1
+ Misses 29606 29601 -5
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more.
|

Problem solved
Fixes #5225
PR-Codex overview
This PR focuses on sanitizing block explorer URLs by introducing utility functions for formatting transaction and address URLs. This ensures consistent URL construction across various components in the
thirdwebpackage.Detailed summary
formatExplorerTxUrlfunction to format transaction URLs.formatExplorerAddressUrlfunction to format address URLs.FiatTxDetailsTable.tsxWalletTransactionHistory.tsxTransactionsScreen.tsxExecutingScreen.tsxFiatSteps.tsxSwapDetailsScreen.tsx