-
Notifications
You must be signed in to change notification settings - Fork 619
Fix MaskedAvatar and PublisherAvatar sizing issues, improved loading & fallback states #5238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MaskedAvatar and PublisherAvatar sizing issues, improved loading & fallback states #5238
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5238 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 1068 1068
Lines 55380 55380
Branches 3975 3975
=======================================
Hits 25082 25082
Misses 29606 29606
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
b4a8e1d to
f926e06
Compare
f926e06 to
f35e72f
Compare
f35e72f to
d697847
Compare
Merge activity
|
…& fallback states (#5238) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on updating the `PublisherAvatar` component usage across several files, replacing the `boxSize` prop with a `className` prop for styling. Additionally, it enhances the `Img` component with improved loading behavior. ### Detailed summary - Replaced `boxSize` with `className` in `PublisherAvatar` components in: - `apps/dashboard/src/components/explore/publisher/index.tsx` - `apps/dashboard/src/pages/profile/[profileAddress].tsx` - `apps/dashboard/src/components/contract-components/publisher/publisher-header.tsx` - `apps/dashboard/src/pages/community/ambassadors.tsx` - Updated `MaskedAvatar` component to use `className` instead of `boxSize`. - Modified `MaskedAvatar` component's rendering logic to use a new `Img` component. - Enhanced `Img` component with a loading state and error handling using a `ref`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
d697847 to
436f6b7
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR primarily focuses on updating the
PublisherAvatarandMaskedAvatarcomponents to use aclassNamefor sizing instead of aboxSizeprop. This change enhances styling flexibility and consistency across various usages in the application.Detailed summary
boxSizeprop withclassNameinPublisherAvataracross multiple files.MaskedAvatarto remove theboxSizeprop and use a default size class.Imgcomponent to improve image loading handling withuseRefanduseIsomorphicLayoutEffect.