Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Oct 31, 2024

Screenshot 2024-10-31 at 12 41 52 PM


PR-Codex overview

This PR focuses on updating the SponsoredTransactionsChartCard and related functions to utilize the new UserOpStatsByChain type, enhancing data handling for sponsored transactions by chain, and improving chart data representation.

Detailed summary

  • Changed createUserOpStatsStub to return UserOpStatsByChain[].
  • Updated userOpStats type in SponsoredTransactionsChartCard to UserOpStatsByChain[].
  • Refactored chart data processing to aggregate by chain.
  • Enhanced chart configuration to support dynamic chains.
  • Modified Y-axis data key calculation for total transactions.
  • Updated CSV export format to include chain-specific data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Oct 31, 2024

@vercel
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 6:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 1, 2024 6:12pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 1, 2024 6:12pm
wallet-ui ⬜️ Skipped (Inspect) Nov 1, 2024 6:12pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 57553b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 31, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 31, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 2.9 s (+4.2% 🔺) 3.8 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 6.3 s (-10.62% 🔽) 8.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 204 ms (-52.06% 🔽) 301 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 126 ms (+194.01% 🔺) 136 ms
thirdweb/react (minimal + tree-shaking) 16.98 KB (0%) 340 ms (0%) 477 ms (-19.99% 🔽) 817 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 1, 2024
@gregfromstl gregfromstl self-assigned this Nov 1, 2024
Copy link
Contributor Author

gregfromstl commented Nov 1, 2024

Merge activity

  • Nov 1, 1:48 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 1, 1:48 PM EDT: A user added this pull request to the Graphite merge queue.
  • Nov 1, 2:12 PM EDT: A user merged this pull request with the Graphite merge queue.

)

![Screenshot 2024-10-31 at 12 41 52 PM](https://github.com/user-attachments/assets/1eb6234c-9c5a-4e82-9ab7-4252dc1c1a8c)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `SponsoredTransactionsChartCard` component to handle user operation statistics by chain, improving data visualization and functionality.

### Detailed summary
- Changed `UserOpStats` to `UserOpStatsByChain` in `createUserOpStatsStub`.
- Updated chart data structure to support multiple chains.
- Modified `SponsoredTransactionsChartCard` to visualize data by chain.
- Enhanced data aggregation and display logic.
- Updated chart configuration to include dynamic chains.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 18:01 Inactive
@codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (13fc6f5) to head (57553b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5252   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1067     1067           
  Lines       55433    55433           
  Branches     3991     3991           
=======================================
  Hits        25148    25148           
  Misses      29594    29594           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 13fc6f5
packages 40.40% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app graphite-app bot merged commit 57553b7 into main Nov 1, 2024
31 checks passed
@graphite-app graphite-app bot deleted the greg/cnct-2167 branch November 1, 2024 18:12
@vercel vercel bot temporarily deployed to Production – docs-v2 November 1, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 1, 2024 18:12 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 1, 2024 18:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants