[SDK] Consolidate more tests - reduce contract deployment #5258
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| import { type Abi, toFunctionSelector } from "viem"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { ANVIL_CHAIN } from "~test/chains.js"; | ||
| import { TEST_CONTRACT_URI } from "~test/ipfs-uris.js"; | ||
| import { TEST_CLIENT } from "~test/test-clients.js"; | ||
| import { TEST_ACCOUNT_B } from "~test/test-wallets.js"; | ||
| import { resolveContractAbi } from "../../contract/actions/resolve-abi.js"; | ||
| import { type ThirdwebContract, getContract } from "../../contract/contract.js"; | ||
| import { name } from "../../extensions/common/read/name.js"; | ||
| import { sendAndConfirmTransaction } from "../../transaction/actions/send-and-confirm-transaction.js"; | ||
| import { parseNFT } from "../../utils/nft/parseNft.js"; | ||
| import { deployERC721Contract } from "../prebuilts/deploy-erc721.js"; | ||
| import { tokenURI } from "./__generated__/IERC721A/read/tokenURI.js"; | ||
| import { setTokenURI } from "./__generated__/INFTMetadata/write/setTokenURI.js"; | ||
| import { getNFT, isGetNFTSupported } from "./read/getNFT.js"; | ||
| import { mintTo } from "./write/mintTo.js"; | ||
|
|
||
| const client = TEST_CLIENT; | ||
| const chain = ANVIL_CHAIN; | ||
| const account = TEST_ACCOUNT_B; | ||
|
|
||
| let token721Contract: ThirdwebContract; | ||
|
|
||
| describe.runIf(process.env.TW_SECRET_KEY)("deployERC721", () => { | ||
| it("should deploy ERC721 token", async () => { | ||
| const address = await deployERC721Contract({ | ||
| client, | ||
| chain, | ||
| account, | ||
| type: "TokenERC721", | ||
| params: { | ||
| name: "NFTCollection", | ||
| contractURI: TEST_CONTRACT_URI, | ||
| }, | ||
| }); | ||
| expect(address).toBeDefined(); | ||
| token721Contract = getContract({ | ||
| client: TEST_CLIENT, | ||
| chain: ANVIL_CHAIN, | ||
| address, | ||
| }); | ||
| const deployedName = await name({ contract: token721Contract }); | ||
| expect(deployedName).toBe("NFTCollection"); | ||
| }); | ||
|
|
||
| it("should mint an nft when passed an object", async () => { | ||
| const transaction = mintTo({ | ||
| contract: token721Contract, | ||
| nft: { name: "token 0" }, | ||
| to: account.address, | ||
| }); | ||
| await sendAndConfirmTransaction({ | ||
| transaction, | ||
| account, | ||
| }); | ||
|
|
||
| const nft = await getNFT({ contract: token721Contract, tokenId: 0n }); | ||
| expect(nft.metadata.name).toBe("token 0"); | ||
| }); | ||
|
|
||
| it("should mint an nft when passed a string", async () => { | ||
| const transaction = mintTo({ | ||
| contract: token721Contract, | ||
| nft: "ipfs://fake-token-uri", | ||
| to: account.address, | ||
| }); | ||
| await sendAndConfirmTransaction({ | ||
| transaction, | ||
| account, | ||
| }); | ||
| const _uri = await tokenURI({ contract: token721Contract, tokenId: 1n }); | ||
| expect(_uri).toBe("ipfs://fake-token-uri"); | ||
| }); | ||
|
|
||
| it("isGetNFTsSupported should work", async () => { | ||
| const abi = await resolveContractAbi<Abi>(token721Contract); | ||
| const selectors = abi | ||
| .filter((f) => f.type === "function") | ||
| .map((f) => toFunctionSelector(f)); | ||
| expect(isGetNFTSupported(selectors)).toBe(true); | ||
| }); | ||
|
|
||
| it("should return a default value if the URI of the token doesn't exist", async () => { | ||
|
Member
There was a problem hiding this comment. What's the value of moving these tests around? Feels like unnecessary work. Would you rather focus on actually writing new tests on areas that aren't covered. You can check the uncovered areas on codecov, any file/folder with low coverage is what you should focus on. All of react for example is particularly low
Contributor
Author
There was a problem hiding this comment. I want to put the tests for token standards into the following structures: to speed up the tests in general and (somehow) avoid the issue with out-of-gas + timeout |
||
| /** | ||
| * mint a token, then purposefully change that token's URI to an empty string, using setTokenURI | ||
| */ | ||
| await sendAndConfirmTransaction({ | ||
| transaction: setTokenURI({ | ||
| contract: token721Contract, | ||
| tokenId: 1n, | ||
| // Need to have some spaces because NFTMetadata.sol does not allow to update an empty value | ||
| uri: " ", | ||
| }), | ||
| account, | ||
| }); | ||
|
|
||
| expect( | ||
| await getNFT({ contract: token721Contract, tokenId: 1n }), | ||
| ).toStrictEqual( | ||
| parseNFT( | ||
| { | ||
| id: 1n, | ||
| type: "ERC721", | ||
| uri: "", | ||
| }, | ||
| { | ||
| tokenId: 1n, | ||
| tokenUri: "", | ||
| type: "ERC721", | ||
| owner: null, | ||
| }, | ||
| ), | ||
| ); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can You still pass a contract uri here? Was useful to skip the ipsy upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added back