Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 2, 2024

Fixes CNCT-2185


PR-Codex overview

This PR focuses on updating the from date parameter in the getInAppWalletUsage function calls to retrieve data from the last 30 days instead of the first day of the current month.

Detailed summary

  • In layout.tsx, changed from date in getInAppWalletUsage from the first day of the current month to 30 days ago using subDays.
  • In header.tsx, similarly updated from date in getInAppWalletUsage to 30 days ago using subDays.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2024

⚠️ No Changeset found

Latest commit: 7d36418

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 2:32am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 2, 2024 2:32am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 2, 2024 2:32am
wallet-ui ⬜️ Skipped (Inspect) Nov 2, 2024 2:32am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 2, 2024
Comment on lines 45 to 49
from: new Date(
new Date().getFullYear(),
new Date().getMonth(),
new Date().getDate() - 30,
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using date-fns for this instead of hand-rolling it

@codecov
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (412fb5d) to head (7d36418).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5271   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1067     1067           
  Lines       55449    55449           
  Branches     3989     3989           
=======================================
  Hits        25157    25157           
  Misses      29601    29601           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 412fb5d
packages 40.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@linear
Copy link

linear bot commented Nov 2, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 3.3 s (+2.26% 🔺) 4.1 s
thirdweb (cjs) 102.88 KB (0%) 2.1 s (0%) 7.5 s (-8.14% 🔽) 9.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 252 ms (+17.35% 🔺) 349 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 119 ms (+104.65% 🔺) 129 ms
thirdweb/react (minimal + tree-shaking) 17 KB (0%) 341 ms (0%) 548 ms (+28.76% 🔺) 888 ms

@gregfromstl gregfromstl force-pushed the fix/in-app-analytics-mau branch from 2caddfb to 2984200 Compare November 2, 2024 01:12
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 01:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 01:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 01:12 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 2, 2024
Copy link
Contributor Author

gregfromstl commented Nov 2, 2024

Merge activity

  • Nov 1, 9:14 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 1, 9:32 PM EDT: A user added this pull request to the Graphite merge queue.
  • Nov 1, 10:33 PM EDT: A user merged this pull request with the Graphite merge queue.

Fixes CNCT-2185

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the date range for fetching in-app wallet usage statistics from the start of the current month to the last 30 days, improving the relevance of the data displayed.

### Detailed summary
- In `layout.tsx`:
  - Changed `from` date in `getInAppWalletUsage` from the start of the current month to 30 days ago using `subDays`.

- In `header.tsx`:
  - Updated `from` date in `getInAppWalletUsage` similarly to 30 days ago with `subDays`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the fix/in-app-analytics-mau branch from 2984200 to 7d36418 Compare November 2, 2024 02:23
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 02:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 02:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 02:23 Inactive
@graphite-app graphite-app bot merged commit 7d36418 into main Nov 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the fix/in-app-analytics-mau branch November 2, 2024 02:33
@vercel vercel bot temporarily deployed to Production – wallet-ui November 2, 2024 02:33 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 2, 2024 02:33 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 2, 2024 02:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants