-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Fix: MAU date range #5271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
| from: new Date( | ||
| new Date().getFullYear(), | ||
| new Date().getMonth(), | ||
| new Date().getDate() - 30, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using date-fns for this instead of hand-rolling it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5271 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1067 1067
Lines 55449 55449
Branches 3989 3989
=======================================
Hits 25157 25157
Misses 29601 29601
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
2caddfb to
2984200
Compare
Merge activity
|
Fixes CNCT-2185 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the date range for fetching in-app wallet usage statistics from the start of the current month to the last 30 days, improving the relevance of the data displayed. ### Detailed summary - In `layout.tsx`: - Changed `from` date in `getInAppWalletUsage` from the start of the current month to 30 days ago using `subDays`. - In `header.tsx`: - Updated `from` date in `getInAppWalletUsage` similarly to 30 days ago with `subDays`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
2984200 to
7d36418
Compare
Fixes CNCT-2185
PR-Codex overview
This PR focuses on updating the
fromdate parameter in thegetInAppWalletUsagefunction calls to retrieve data from the last 30 days instead of the first day of the current month.Detailed summary
layout.tsx, changedfromdate ingetInAppWalletUsagefrom the first day of the current month to 30 days ago usingsubDays.header.tsx, similarly updatedfromdate ingetInAppWalletUsageto 30 days ago usingsubDays.