Skip to content

[SDK] Fix: Track chain ID on transaction events #5272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024
Merged

[SDK] Fix: Track chain ID on transaction events #5272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-papayas-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Tracks transaction chain IDs
1 change: 1 addition & 0 deletions packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@

trackTransaction({
client: client,
chainId: tx.chainId,

Check warning on line 310 in packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts#L310 

Added line #L310 was not covered by tests
walletAddress: getAddress(address),
walletType: COINBASE,
transactionHash,
Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ export class EnclaveWallet implements IWebWallet {
trackTransaction({
client,
ecosystem,
chainId: tx.chainId,
walletAddress: address,
walletType: "inApp",
transactionHash,
Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/wallets/in-app/web/lib/iframe-wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ export class IFrameWallet implements IWebWallet {

trackTransaction({
client,
chainId: tx.chainId,
walletAddress: address,
walletType: "inApp",
transactionHash,
Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/wallets/injected/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@

trackTransaction({
client,
chainId: tx.chainId,

Check warning on line 165 in packages/thirdweb/src/wallets/injected/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/injected/index.ts#L165 

Added line #L165 was not covered by tests
walletAddress: getAddress(address),
walletType: id,
transactionHash,
Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/wallets/wallet-connect/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@
walletAddress: getAddress(address),
walletType: "walletConnect",
transactionHash,
chainId: tx.chainId,

Check warning on line 354 in packages/thirdweb/src/wallets/wallet-connect/controller.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/wallet-connect/controller.ts#L354 

Added line #L354 was not covered by tests
contractAddress: tx.to ?? undefined,
gasPrice: tx.gasPrice,
});
Expand Down
Loading