fix: Engine deletion endpoint requires engineId #5276
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arcoraven
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5276 +/- ##
=======================================
Coverage 45.37% 45.37%
=======================================
Files 1067 1067
Lines 55446 55451 +5
Branches 3989 3992 +3
=======================================
+ Hits 25157 25161 +4
- Misses 29598 29599 +1
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
| }: DeleteCloudHostedInput) => { | ||
| const res = await fetch( | ||
| `${THIRDWEB_API_HOST}/v2/engine/deployments/${deploymentId}/infrastructure/delete`, | ||
| `${THIRDWEB_API_HOST}/v2/engine/deployments/${deploymentId}/infrastructure/delete?engineId=${engineId}`, |
There was a problem hiding this comment.
feels a little weird to have this in a query param for a POST request?
also isn't a deploymentId linked to an engineId already ?
There was a problem hiding this comment.
Let me handle this from the API server end. It's less explicit but should it should resolve for for most users and is the correct longer term approach.
PR-Codex overview
This PR focuses on enhancing the
DeleteCloudHostedInputinterface and theuseForminitialization to includeengineId, allowing for more specific deletion requests in the engine instances table.Detailed summary
engineIdto theDeleteCloudHostedInputinterface.useFormhook inengine-instances-table.tsxto setengineIdfrominstance.id.engineIdin the fetch URL for deletion requests.