Skip to content

fix: Engine deletion endpoint requires engineId #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Engine deletion endpoint requires engineId #5276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/dashboard/src/@3rdweb-sdk/react/hooks/useEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ export function useEngineRemoveFromDashboard() {
}

export interface DeleteCloudHostedInput {
engineId: string;
deploymentId: string;
reason: "USING_SELF_HOSTED" | "TOO_EXPENSIVE" | "MISSING_FEATURES" | "OTHER";
feedback: string;
Expand All @@ -273,12 +274,13 @@ export function useEngineDeleteCloudHosted() {

return useMutation({
mutationFn: async ({
engineId,
deploymentId,
reason,
feedback,
}: DeleteCloudHostedInput) => {
const res = await fetch(
`${THIRDWEB_API_HOST}/v2/engine/deployments/${deploymentId}/infrastructure/delete`,
`${THIRDWEB_API_HOST}/v2/engine/deployments/${deploymentId}/infrastructure/delete?engineId=${engineId}`,
Copy link
Member

@joaquim-verges joaquim-verges Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a little weird to have this in a query param for a POST request?

also isn't a deploymentId linked to an engineId already ?

Copy link
Contributor Author

@arcoraven arcoraven Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me handle this from the API server end. It's less explicit but should it should resolve for for most users and is the correct longer term approach.

{
method: "POST",
headers: {
Expand Down
1 change: 1 addition & 0 deletions apps/dashboard/src/components/engine/engine-instances-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ function DeleteSubscriptionModalContent(props: {
const [ackDeletion, setAckDeletion] = useState(false);
const form = useForm<DeleteCloudHostedInput>({
defaultValues: {
engineId: instance.id,
deploymentId: instance.deploymentId,
},
reValidateMode: "onChange",
Expand Down
Loading