-
Notifications
You must be signed in to change notification settings - Fork 619
Fix /dashboards path redirecting to /login #5291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
11-05-fix__dashboards_path_redirecting_to__login
Nov 4, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,16 @@ | ||
| const LOGGED_IN_ONLY_PATHS = [ | ||
| // anything that _starts_ with /dashboard is logged in only | ||
| "/dashboard", | ||
| // team pages are logged in only | ||
| "/team", | ||
| // anything that _starts_ with /cli is logged in only | ||
| "/cli", | ||
| // publish page | ||
| "/contracts/publish", | ||
| ]; | ||
|
|
||
| export function isLoginRequired(pathname: string) { | ||
| return LOGGED_IN_ONLY_PATHS.some((path) => pathname.startsWith(path)); | ||
| // remove '/' in front and then split by '/' | ||
| const paths = pathname.slice(1).split("/"); | ||
|
|
||
| // /dashboard, /team, /cli | ||
| if (paths[0] === "dashboard" || paths[0] === "team" || paths[0] === "cli") { | ||
| return true; | ||
| } | ||
|
|
||
| // /contracts/publish | ||
| if (paths[0] === "contracts" && paths[1] === "publish") { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.