Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 5, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on fixing the Pay UI to ensure it correctly switches the connected wallet's chain when necessary.

Detailed summary

  • Updated the condition for switchChainRequired in BuyScreen.tsx to check if the wallet's chain ID matches the fromChain.id using props.payer.wallet.getChain()?.id instead of props.payer.chain.id.
  • Added a patch entry for thirdweb in the changelog.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:04am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:04am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:04am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:04am

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: a804fb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review November 5, 2024 01:43
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 860 ms (0%) 1.1 s (+86.69% 🔺) 1.9 s
thirdweb (cjs) 103.02 KB (0%) 2.1 s (0%) 1.8 s (+37.23% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 208 ms (+408.45% 🔺) 305 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 225 ms (+799.07% 🔺) 235 ms
thirdweb/react (minimal + tree-shaking) 17.57 KB (0%) 352 ms (0%) 249 ms (-13.55% 🔽) 600 ms

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (70ed73e) to head (a804fb5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5302      +/-   ##
==========================================
+ Coverage   45.44%   45.47%   +0.02%     
==========================================
  Files        1067     1067              
  Lines       55459    55487      +28     
  Branches     4009     4015       +6     
==========================================
+ Hits        25206    25231      +25     
- Misses      29562    29565       +3     
  Partials      691      691              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 70ed73e
packages 40.54% <0.00%> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...act/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx 0.09% <0.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants