feat: Add smart backend wallet types #5303
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arcoraven
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5303 +/- ##
=======================================
Coverage 45.56% 45.56%
=======================================
Files 1067 1067
Lines 55487 55487
Branches 4031 4031
=======================================
Hits 25283 25283
Misses 29514 29514
Partials 690 690
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
looks like the build is failing
Merge activity
|
https://linear.app/thirdweb/issue/INFRA-404/add-sbw-to-dashboard <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the backend wallet functionality within the application. It introduces new wallet types, updates wallet configuration handling, and refines the user interface for better usability. ### Detailed summary - Added `"SMART_BACKEND_WALLETS"` to the wallet type constants. - Introduced new `EngineBackendWalletType` options for smart wallets. - Updated `EngineBackendWalletOptions` with smart wallet configurations. - Changed `tabContent` to use `Partial<Record<EngineBackendWalletType, React.ReactNode>>`. - Enhanced wallet type selection logic based on smart wallet support. - Added `FormDescription` to provide information on backend wallet types. - Updated form validation to include smart wallet configurations. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
arcoraven
force-pushed
the
ph/addSmartWalletTypes
branch
from
3b194d6 to
cc47b7b
Compare
https://linear.app/thirdweb/issue/INFRA-404/add-sbw-to-dashboard
PR-Codex overview
This PR enhances the backend wallet functionality in the
3rdweb-sdkby adding support for new wallet types, updating the configuration logic, and improving user feedback in the UI.Detailed summary
"SMART_BACKEND_WALLETS"to the subscription types.EngineBackendWalletTypeoptions for smart wallets.EngineBackendWalletOptionswith smart wallet configurations.tabContentto usePartial<Record<EngineBackendWalletType, React.ReactNode>>.FormDescriptionto provide users with more information on backend wallet types.