[js] fix enclave wallet signing #5315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 87e736d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
0xFirekeeper
approved these changes
Nov 6, 2024
Contributor
size-limit report 📦
|
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5315 +/- ##
==========================================
+ Coverage 45.59% 45.61% +0.02%
==========================================
Files 1069 1068 -1
Lines 55584 55556 -28
Branches 4045 4047 +2
==========================================
- Hits 25342 25341 -1
+ Misses 29552 29525 -27
Partials 690 690
*This pull request uses carry forward flags. Click here to find out more. |
joaquim-verges
approved these changes
Nov 6, 2024
https://linear.app/thirdweb/issue/CNCT-2099/enclaves-malform-contract-call-transactions <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing an error related to ecosystem signing with data in the `thirdweb` wallet implementation. It adjusts how transaction details are processed, particularly the `to` and `data` fields. ### Detailed summary - Updated the `to` field in the transaction object to use `getAddress(tx.to)` instead of a fallback to `undefined`. - Changed the `data` field assignment to directly use `tx.data` without transformation. - The rest of the transaction fields remain unchanged. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/fix-enclave-wallet-signing-
branch
from
356aa9f to
87e736d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/CNCT-2099/enclaves-malform-contract-call-transactions
PR-Codex overview
This PR focuses on fixing the ecosystem signing process by addressing a data error in the
thirdwebwallet implementation.Detailed summary
tofield in thetransactionobject to usegetAddress(tx.to)instead of casting toHex.datafield to directly assigntx.datawithout modification.value,gas,nonce) remain unchanged.