-
Notifications
You must be signed in to change notification settings - Fork 620
[Dashboard | SDK] Feature: Ref values for address params in publish #5360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5360 +/- ##
==========================================
+ Coverage 51.25% 51.42% +0.16%
==========================================
Files 1092 1093 +1
Lines 57375 57524 +149
Branches 4689 4723 +34
==========================================
+ Hits 29410 29583 +173
+ Misses 27249 27225 -24
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx
Show resolved
Hide resolved
Merge activity
|
…5360) PROT-932 PROT-864 ## Problem solved https://linear.app/thirdweb/project/[contract-tooling]-deployment-publish-flow-revamp-0194e04e2a84/overview Handle contract refs in publish form -- Resolve / deploy all linked contracts in publish metadata, and pass the addresses as constructor args for corresponding params. It recursively deploys all referenced contracts through the ref chain, before deploying the main contract. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the contract deployment and parameter handling in the thirdweb platform, introducing dynamic parameters, improved UI components, and better error handling for contract interactions. ### Detailed summary - Updated `deploy-with-abi.ts` to return the contract address instead of throwing an error if already deployed. - Enhanced UI components in `string-input.tsx` and `raw-input.tsx` for better user experience. - Added dynamic parameter handling in multiple components. - Introduced new types for dynamic parameters in `deploy-metadata.ts`. - Improved form handling in `FormFieldSetup` and related components. - Added reference contract input fields in various components for dynamic contract deployments. - Enhanced error handling and validation in the deployment forms. - Updated component structure for better maintainability and clarity. > The following files were skipped due to too many changes: `apps/dashboard/src/components/contract-components/contract-publish-form/contract-params-fieldset.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
2a3d99b to
d9fb544
Compare
PROT-932
PROT-864
Problem solved
https://linear.app/thirdweb/project/[contract-tooling]-deployment-publish-flow-revamp-0194e04e2a84/overview
Handle contract refs in publish form -- Resolve / deploy all linked contracts in publish metadata, and pass the addresses as constructor args for corresponding params.
It recursively deploys all referenced contracts through the ref chain, before deploying the main contract.
PR-Codex overview
This PR focuses on enhancing the deployment and management of smart contracts by introducing dynamic parameters and improving UI components for contract publishing, including better handling of reference contracts and constructor parameters.
Detailed summary
deploy-with-abi.tsto return address instead of throwing an error.string-input.tsxfor improved responsiveness.dynamicValuesupport in various components for constructor parameters.FormFieldSetupto accept optionalclassName.DynamicParamstype for flexible contract deployment.implConstructorParamsin contract deployment logic.