Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 9, 2024

PR-Codex overview

This PR focuses on handling the case where publisherProfile can be null, ensuring that the UI components render correctly without errors when publisherProfile is not available.

Detailed summary

  • Updated publisherProfile type from ProfileMetadata to ProfileMetadata | null.
  • Added optional chaining (?.) to safely access bio property.
  • Wrapped PublisherSocials and EditProfile components with conditional rendering to check for publisherProfile.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: b30c4d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 6:57pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 13, 2024 6:57pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 13, 2024 6:57pm
wallet-ui ⬜️ Skipped (Inspect) Nov 13, 2024 6:57pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 19:34 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 9, 2024
Copy link
Member Author

jnsdls commented Nov 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@jnsdls jnsdls force-pushed the handle_null_publisher_profile branch from 0444a72 to 38d6e8c Compare November 9, 2024 19:34
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 19:34 Inactive
@jnsdls jnsdls marked this pull request as ready for review November 9, 2024 19:34
@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (6b853df) to head (b30c4d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5372   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6b853df
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 1.8 s (-20.36% 🔽) 2.7 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 4.2 s (-0.15% 🔽) 6.3 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 309 ms (+171.95% 🔺) 424 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 74 ms (-45.63% 🔽) 84 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 397 ms (-30.8% 🔽) 773 ms

@gregfromstl gregfromstl changed the title handle null publisher profile [Dashboard] Fix: Handle null publisher profile Nov 13, 2024
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 13, 2024
Copy link
Contributor

gregfromstl commented Nov 13, 2024

Merge activity

  • Nov 13, 1:34 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 1:34 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 1:57 PM EST: A user merged this pull request with the Graphite merge queue.

@gregfromstl gregfromstl force-pushed the handle_null_publisher_profile branch from 38d6e8c to b30c4d0 Compare November 13, 2024 18:42
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 18:42 Inactive
@graphite-app graphite-app bot merged commit b30c4d0 into main Nov 13, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the handle_null_publisher_profile branch November 13, 2024 18:57
@vercel vercel bot temporarily deployed to Production – wallet-ui November 13, 2024 18:57 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 13, 2024 18:57 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 13, 2024 18:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants