Skip to content

Remove invalid modules loading spinner in contract deploy page #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Remove invalid modules loading spinner in contract deploy page #5379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
"use client";

import { Spinner } from "@/components/ui/Spinner/Spinner";
import { Alert, AlertTitle } from "@/components/ui/alert";
import { Button } from "@/components/ui/button";
import { Checkbox, CheckboxWithLabel } from "@/components/ui/checkbox";
Expand Down Expand Up @@ -765,18 +763,13 @@ export const CustomContractForm: React.FC<CustomContractFormProps> = ({
);
})}

{isModular &&
(modules?.length ? (
<ModularContractDefaultModulesFieldset
form={form}
modules={modules}
isTWPublisher={isTWPublisher}
/>
) : (
<div className="flex min-h-[250px] items-center justify-center">
<Spinner className="size-8" />
</div>
))}
{isModular && modules && modules.length > 0 && (
<ModularContractDefaultModulesFieldset
form={form}
modules={modules}
isTWPublisher={isTWPublisher}
/>
)}

{advancedParams.length > 0 && (
<Accordion allowToggle>
Expand Down
Loading