-
Notifications
You must be signed in to change notification settings - Fork 619
Updated 404 page in dashboard, Add to App router #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5387 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 1070 1070
Lines 55671 55671
Branches 4081 4081
=======================================
Hits 25446 25446
Misses 29536 29536
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
c2bd591 to
86f5bec
Compare
size-limit report 📦
|
86f5bec to
118a428
Compare
Merge activity
|
 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on creating a new `NotFound` page component and refactoring the existing 404 page to utilize this new component, improving code organization and reusability. ### Detailed summary - Added `NotFoundPage` component in `apps/dashboard/src/components/not-found-page.tsx`. - Created a structured layout for the 404 error message with links. - Refactored the `PageNotFound` component in `apps/dashboard/src/pages/404.tsx` to use the new `NotFoundPage`. - Removed unused imports and components related to the old 404 page design. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
118a428 to
9584885
Compare

PR-Codex overview
This PR introduces a new
NotFoundPagecomponent to replace the existing404page implementation. It streamlines the code and enhances the user interface for better navigation when a page is not found.Detailed summary
NotFoundPagecomponent inapps/dashboard/src/components/not-found-page.tsx.404page logic fromapps/dashboard/src/pages/404.tsx.404.tsxto render the newNotFoundPage.