Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 11, 2024

image.png


PR-Codex overview

This PR introduces a new NotFoundPage component to replace the existing 404 page implementation. It streamlines the code and enhances the user interface for better navigation when a page is not found.

Detailed summary

  • Added NotFoundPage component in apps/dashboard/src/components/not-found-page.tsx.
  • Created a structured layout with error message and navigation links.
  • Removed old 404 page logic from apps/dashboard/src/pages/404.tsx.
  • Updated 404.tsx to render the new NotFoundPage.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 10:49pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 11, 2024 10:49pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 11, 2024 10:49pm
wallet-ui ⬜️ Skipped (Inspect) Nov 11, 2024 10:49pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 21:34 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: 9584885

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 11, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as ready for review November 11, 2024 21:35
@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (c6310e6) to head (9584885).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5387   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c6310e6
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank force-pushed the 11-12-updated_404_page_add_to_app_router branch from c2bd591 to 86f5bec Compare November 11, 2024 21:37
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 21:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 21:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 21:37 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 528 ms (+164.69% 🔺) 1.4 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 471 ms (-33.24% 🔽) 2.6 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 12 ms (+7.65% 🔺) 110 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 11 ms (+226.85% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 50 ms (+5.83% 🔺) 402 ms

@MananTank MananTank force-pushed the 11-12-updated_404_page_add_to_app_router branch from 86f5bec to 118a428 Compare November 11, 2024 21:40
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 21:41 Inactive
@MananTank MananTank changed the title Updated 404 page, Add to App router Updated 404 page in dashboard, Add to App router Nov 11, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Merge activity

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/yNOf1svJ8o3zjO7zQouZ/cb7fcb59-0d12-4072-a426-3c9863302d1f.png)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on creating a new `NotFound` page component and refactoring the existing 404 page to utilize this new component, improving code organization and reusability.

### Detailed summary
- Added `NotFoundPage` component in `apps/dashboard/src/components/not-found-page.tsx`.
- Created a structured layout for the 404 error message with links.
- Refactored the `PageNotFound` component in `apps/dashboard/src/pages/404.tsx` to use the new `NotFoundPage`.
- Removed unused imports and components related to the old 404 page design.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-12-updated_404_page_add_to_app_router branch from 118a428 to 9584885 Compare November 11, 2024 22:46
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 11, 2024 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 11, 2024 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 11, 2024 22:46 Inactive
@graphite-app graphite-app bot merged commit 9584885 into main Nov 11, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 11-12-updated_404_page_add_to_app_router branch November 11, 2024 22:50
@vercel vercel bot temporarily deployed to Production – docs-v2 November 11, 2024 22:50 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 11, 2024 22:50 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 11, 2024 22:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants