Winston/cnct 2311 pro cannot sign transaction with in app wallet #5390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6771cfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5390 +/- ##
==========================================
- Coverage 45.32% 45.30% -0.03%
==========================================
Files 1067 1068 +1
Lines 55405 55433 +28
Branches 3999 4000 +1
==========================================
+ Hits 25111 25112 +1
- Misses 29607 29634 +27
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
joaquim-verges
approved these changes
Nov 12, 2024
| chainId: toHex(tx.chainId), | ||
| }; | ||
|
|
||
| if (tx.maxFeePerGas) { |
Member
There was a problem hiding this comment.
shouldn't we check the type here too?
nitpick: in general i prefer checking if value !== undefined rather than typeof bigint
ElasticBottle
added a commit
that referenced
this pull request
Nov 12, 2024
ElasticBottle
force-pushed
the
winston/cnct-2311-pro-cannot-sign-transaction-with-in-app-wallet
branch
from
ee83b43 to
963a30f
Compare
graphite-app
bot
removed
the
merge-queue
gregfromstl
added
the
merge-queue
## Problem solved https://linear.app/thirdweb/issue/CNCT-2311/pro-cannot-sign-transaction-with-in-app-wallet <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the transaction signing process in the `enclave-wallet` by ensuring proper type checks for various transaction properties, specifically handling cases for `bigint` and `number` types. ### Detailed summary - Updated the handling of `tx.value`, `tx.gas`, `tx.nonce`, `tx.maxPriorityFeePerGas`, and `tx.gasPrice` to check their types before processing. - Ensured that `tx.value`, `tx.gas`, and `tx.maxPriorityFeePerGas` are only processed if they are of type `bigint`. - Adjusted the handling of `tx.nonce` to support both `number` and fallback to `eth_getTransactionCount`. - Maintained a 10% buffer for `tx.gas` calculations. - Updated the assignment of `transaction.maxFeePerGas` and `transaction.type` based on the presence of `tx.maxFeePerGas`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
winston/cnct-2311-pro-cannot-sign-transaction-with-in-app-wallet
branch
from
963a30f to
6771cfe
Compare
graphite-app
bot
deleted the
winston/cnct-2311-pro-cannot-sign-transaction-with-in-app-wallet
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
https://linear.app/thirdweb/issue/CNCT-2311/pro-cannot-sign-transaction-with-in-app-wallet
PR-Codex overview
This PR focuses on improving the transaction signing process in the
thirdwebwallet by ensuring that the types of transaction parameters are properly checked before processing them.Detailed summary
tx.value,tx.gas,tx.nonce,tx.maxPriorityFeePerGas, andtx.gasPriceto check their types before conversion to hex.tx.maxFeePerGasandtx.gasPriceare set based on type checks.tx.gas.