add nebula service definition #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ae7367 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iuwqyir
requested review from
MananTank,
arcoraven and
joaquim-verges
as code owners
jnsdls
approved these changes
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5401 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1068 1068
Lines 55433 55433
Branches 4000 4000
=======================================
Hits 25112 25112
Misses 29634 29634
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
Contributor
Author
Merge activity
|
iuwqyir
added a commit
that referenced
this pull request
Nov 12, 2024
## Problem solved Added Nebula service scope to the service definitions and included it in the hidden services list.
iuwqyir
force-pushed
the
11-12-add_nebula_service_definition
branch
from
0e0b075 to
1865acf
Compare
graphite-app
bot
added
merge-queue
## Problem solved https://linear.app/thirdweb/issue/BLOCK-412/add-api-key-scope Added Nebula service scope to the service definitions and included it in the hidden services list. <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces the `nebula` service scope to the project and updates the related configurations and validations accordingly. It also modifies the pull request body check to include the `BLOCK` keyword. ### Detailed summary - Added `nebula` service scope in `packages/service-utils/src/core/services.ts` with properties: `name`, `title`, and `description`. - Updated `HIDDEN_SERVICES` in `apps/dashboard/src/components/settings/ApiKeys/validations.ts` to include `nebula`. - Modified the pull request body check in `.github/workflows/linear.yml` to include `BLOCK`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
iuwqyir
force-pushed
the
11-12-add_nebula_service_definition
branch
from
9ae7367 to
040e478
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
https://linear.app/thirdweb/issue/BLOCK-412/add-api-key-scope
Added Nebula service scope to the service definitions and included it in the hidden services list.
PR-Codex overview
This PR introduces the
nebulaservice scope to the project and updates related configurations and validations, enhancing the API key settings and workflow checks.Detailed summary
nebulaservice scope inpackages/service-utils/src/core/services.ts.HIDDEN_SERVICESinapps/dashboard/src/components/settings/ApiKeys/validations.tsto includenebula..github/workflows/linear.ymlto check for theBLOCKkeyword in pull request bodies.