Skip to content

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Nov 13, 2024

Problem solved

https://linear.app/thirdweb/issue/BLOCK-412/add-api-key-scope

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on removing the nebula service from the service-utils package, simplifying the service structure.

Detailed summary

  • Removed the nebula service definition from the services.ts file, including its name, title, description, and actions.
  • Adjusted the structure to reflect the removal of the nebula service.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:19pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:19pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:19pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:19pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 17:05 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 340d90f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

iuwqyir commented Nov 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iuwqyir and the rest of your teammates on Graphite Graphite

@iuwqyir iuwqyir marked this pull request as ready for review November 13, 2024 17:05
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (040e478) to head (d45cbd4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5409      +/-   ##
==========================================
+ Coverage   45.30%   45.52%   +0.22%     
==========================================
  Files        1068     1070       +2     
  Lines       55433    55665     +232     
  Branches     4000     4030      +30     
==========================================
+ Hits        25112    25341     +229     
- Misses      29634    29637       +3     
  Partials      687      687              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 040e478
packages 40.62% <ø> (+0.30%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 13 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 2.6 s (+1.56% 🔺) 3.5 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 5.8 s (-2.94% 🔽) 7.9 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 310 ms (-6.98% 🔽) 424 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 85 ms (+106.52% 🔺) 95 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 692 ms (-12.27% 🔽) 1.1 s

@iuwqyir iuwqyir added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 13, 2024
Copy link
Contributor Author

iuwqyir commented Nov 13, 2024

Merge activity

  • Nov 13, 12:19 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@edwardysun edwardysun merged commit e841bfe into main Nov 13, 2024
32 of 33 checks passed
@edwardysun edwardysun deleted the 11-13-remove_nebula_from_service_list branch November 13, 2024 17:21
@jnsdls jnsdls mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants