Skip to content

[SDK] Fix: Limit WC chains connected to 10 for max payload size #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[SDK] Fix: Limit WC chains connected to 10 for max payload size #5427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/thirdweb/src/wallets/wallet-connect/receiver/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,19 @@
const {
wallet,
requestHandlers,
chains,
onConnect,
onDisconnect,
client: thirdwebClient,
} = options;
const chains = (() => {
if (options.chains && options.chains.length > 10) {
console.warn(
"WalletConnect: Can specify no more than 10 chains, truncating to the first 10 provided chains...",
);
return options.chains.slice(0, 10);
}

Check warning on line 174 in packages/thirdweb/src/wallets/wallet-connect/receiver/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/wallet-connect/receiver/index.ts#L170-L174 

Added lines #L170 - L174 were not covered by tests
return options.chains;
})();

if (walletConnectClientCache.has(thirdwebClient)) {
return walletConnectClientCache.get(thirdwebClient) as WalletConnectClient;
Expand Down
Loading